js::StackFrame implementation has stray 'toFunction' coercions

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jimb, Assigned: jimb)

Tracking

unspecified
mozilla12
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 586221 [details] [diff] [review]
Remove some unnecessary toFunction() calls applied to JSFunction values.

Some spots in js::StackFrame::initCallFrame and js::ContextStack::pushInlineFrame call the toFunction method of a JSFunction value, which is unnecessary.
Attachment #586221 - Flags: review?(luke)

Comment 1

5 years ago
Comment on attachment 586221 [details] [diff] [review]
Remove some unnecessary toFunction() calls applied to JSFunction values.

nice
Attachment #586221 - Flags: review?(luke) → review+
(Assignee)

Comment 2

5 years ago
Pushed: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=f0eab7fd20af
Try server run: https://tbpl.mozilla.org/?tree=Try&rev=bb47a4683611
Assignee: general → jimb
Status: NEW → ASSIGNED
Flags: in-testsuite+
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla12
(Assignee)

Comment 3

5 years ago
This made it into Mozilla Central, but the bug didn't get closed.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

5 years ago
The commit link above was incorrect; here's the right one.
https://hg.mozilla.org/mozilla-central/rev/89c6efec31a7
You need to log in before you can comment on or make changes to this bug.