Last Comment Bug 715667 - js::StackFrame implementation has stray 'toFunction' coercions
: js::StackFrame implementation has stray 'toFunction' coercions
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla12
Assigned To: Jim Blandy :jimb
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-05 14:17 PST by Jim Blandy :jimb
Modified: 2012-05-08 17:28 PDT (History)
1 user (show)
jimb: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove some unnecessary toFunction() calls applied to JSFunction values. (1.27 KB, patch)
2012-01-05 14:17 PST, Jim Blandy :jimb
luke: review+
Details | Diff | Splinter Review

Description Jim Blandy :jimb 2012-01-05 14:17:51 PST
Created attachment 586221 [details] [diff] [review]
Remove some unnecessary toFunction() calls applied to JSFunction values.

Some spots in js::StackFrame::initCallFrame and js::ContextStack::pushInlineFrame call the toFunction method of a JSFunction value, which is unnecessary.
Comment 1 Luke Wagner [:luke] 2012-01-05 15:07:18 PST
Comment on attachment 586221 [details] [diff] [review]
Remove some unnecessary toFunction() calls applied to JSFunction values.

nice
Comment 3 Jim Blandy :jimb 2012-05-08 17:25:14 PDT
This made it into Mozilla Central, but the bug didn't get closed.
Comment 4 Jim Blandy :jimb 2012-05-08 17:28:18 PDT
The commit link above was incorrect; here's the right one.
https://hg.mozilla.org/mozilla-central/rev/89c6efec31a7

Note You need to log in before you can comment on or make changes to this bug.