Closed Bug 715667 Opened 10 years ago Closed 9 years ago

js::StackFrame implementation has stray 'toFunction' coercions

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: jimb, Assigned: jimb)

Details

Attachments

(1 file)

Some spots in js::StackFrame::initCallFrame and js::ContextStack::pushInlineFrame call the toFunction method of a JSFunction value, which is unnecessary.
Attachment #586221 - Flags: review?(luke)
Comment on attachment 586221 [details] [diff] [review]
Remove some unnecessary toFunction() calls applied to JSFunction values.

nice
Attachment #586221 - Flags: review?(luke) → review+
Pushed: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=f0eab7fd20af
Try server run: https://tbpl.mozilla.org/?tree=Try&rev=bb47a4683611
Assignee: general → jimb
Status: NEW → ASSIGNED
Flags: in-testsuite+
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla12
This made it into Mozilla Central, but the bug didn't get closed.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
The commit link above was incorrect; here's the right one.
https://hg.mozilla.org/mozilla-central/rev/89c6efec31a7
You need to log in before you can comment on or make changes to this bug.