715673 - Hande browser-lastwindow-close events

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Brian Nicholson (:bnicholson)]

We should handle/send browser-lastwindow-close-requested and browser-lastwindow-close-granted as we did in XUL Fennec.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 586226 [details] [diff] [review]
patch


>+        lastBrowser = false;
>+    }
>+    if (lastBrowser) {
>+      // Let everyone know we are closing the last browser window

Add a space between the blocks

Comment 3

[Brian Nicholson (:bnicholson)]

Landed on inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/a9f4c0795560

Comment 4

[Ed Morley [:emorley]]

One of three changesets backed out of inbound due to test coalescing making it hard to identify which caused the native android test failures:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1927c7905f5e

Comment 5

[Brian Nicholson (:bnicholson)]

Passed try tests:
https://tbpl.mozilla.org/?tree=Try&rev=84da3ebd9c39

Re-landed on mozilla-inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/460ffa419de5

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/460ffa419de5

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 586226 [details] [diff] [review]
patch

[Approval Request Comment]
needed to correctly handle saving the session

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 586226 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5cbc92157e7d