Last Comment Bug 715673 - Hande browser-lastwindow-close events
: Hande browser-lastwindow-close events
Product: Firefox for Android
Classification: Client Software
Component: General (show other bugs)
: unspecified
: All Android
P1 normal (vote)
: Firefox 12
Assigned To: Brian Nicholson (:bnicholson)
: Sebastian Kaspari (:sebastian)
Depends on:
  Show dependency treegraph
Reported: 2012-01-05 14:33 PST by Brian Nicholson (:bnicholson)
Modified: 2012-01-16 22:31 PST (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (1.81 KB, patch)
2012-01-05 14:34 PST, Brian Nicholson (:bnicholson)
mark.finkle: review+
akeybl: approval‑mozilla‑aurora+
Details | Diff | Splinter Review

Description User image Brian Nicholson (:bnicholson) 2012-01-05 14:33:20 PST
We should handle/send browser-lastwindow-close-requested and browser-lastwindow-close-granted as we did in XUL Fennec.
Comment 1 User image Brian Nicholson (:bnicholson) 2012-01-05 14:34:29 PST
Created attachment 586226 [details] [diff] [review]
Comment 2 User image Mark Finkle (:mfinkle) (use needinfo?) 2012-01-05 15:08:35 PST
Comment on attachment 586226 [details] [diff] [review]

>+        lastBrowser = false;
>+    }
>+    if (lastBrowser) {
>+      // Let everyone know we are closing the last browser window

Add a space between the blocks
Comment 3 User image Brian Nicholson (:bnicholson) 2012-01-09 11:57:30 PST
Landed on inbound:
Comment 4 User image Ed Morley [:emorley] 2012-01-09 14:47:30 PST
One of three changesets backed out of inbound due to test coalescing making it hard to identify which caused the native android test failures:
Comment 5 User image Brian Nicholson (:bnicholson) 2012-01-10 13:32:55 PST
Passed try tests:

Re-landed on mozilla-inbound:
Comment 6 User image Ed Morley [:emorley] 2012-01-10 18:47:36 PST
Comment 7 User image Mark Finkle (:mfinkle) (use needinfo?) 2012-01-13 09:17:45 PST
Comment on attachment 586226 [details] [diff] [review]

[Approval Request Comment]
needed to correctly handle saving the session
Comment 8 User image Alex Keybl [:akeybl] 2012-01-16 13:14:05 PST
Comment on attachment 586226 [details] [diff] [review]

[Triage Comment]
Mobile only - approved for Aurora.
Comment 9 User image Mark Finkle (:mfinkle) (use needinfo?) 2012-01-16 22:31:03 PST

Note You need to log in before you can comment on or make changes to this bug.