715719 - Venkman not registered in thunderbird tools menu

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Stefan Fleiter (:sfleiter)]

Attachment: Include venkman-overlay-tb.xul in jar to enable registering venkman in Thunderbird tools menu

In Thunderbird venkman from trunk does not get registered in the tools menu.
According to my investigations that is caused by the fact that content/venkman/venkman-overlay-tb.xul but not shipped in the jar file.
See attached patch.

Comment 1

[Stefan Fleiter (:sfleiter)]

Comment on attachment 586269 [details] [diff] [review]
Include venkman-overlay-tb.xul in jar to enable registering venkman in Thunderbird tools menu

I have no experience in the build system and how extensions are built but the attached patch fixes the problem for me and seems logical.

Bug found when trying to test fix of bug 418426.

Comment 2

[:Gijs (he/him)]

Comment on attachment 586269 [details] [diff] [review]
Include venkman-overlay-tb.xul in jar to enable registering venkman in Thunderbird tools menu

rs=me

Can you do a full mercurial export (hg commit with an appropriate message after setting your mercurial name + email)? That'll help me commit this with proper credits to you as the patch author. Thanks! :-)

(more info: https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F )

Comment 3

[Stefan Fleiter (:sfleiter)]

Attachment: Include venkman-overlay-tb.xul in jar to enable registering venkman in Thunderbird tools menu, mq patch [Checkin: Comment 6]

I hope this patch has the correct format.
Thanks a lot for your patience and the pointer to the mq documentation.

Comment 4

[:Gijs (he/him)]

Comment on attachment 586415 [details] [diff] [review]
Include venkman-overlay-tb.xul in jar to enable registering venkman in Thunderbird tools menu, mq patch [Checkin: Comment 6]

r=me

Yay for the bugzilla review reminder emails, and sorry this slipped a few weeks, it got lost...

In the future, note also that in cases like this where you post the exact same patch but with patch formatting details different (or maybe even if you exactly copied instructions regarding code formatting or other trivial changes) it is considered fine to 'carry over' review, that is, you wouldn't have needed to re-request review.

Thanks again for the patch, I'll try to check it in straight away. :-)

Comment 5

[:Gijs (he/him)]

Scratch that, my HG account has been disabled due to inactivity. Re-requesting access, setting checkin-needed in the meantime, we'll see what happens first...

Comment 6

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 586415 [details] [diff] [review]
Include venkman-overlay-tb.xul in jar to enable registering venkman in Thunderbird tools menu, mq patch [Checkin: Comment 6]

http://hg.mozilla.org/venkman/rev/d8acf291d178