Kill unused enums nsWidgetType and nsLanguageSpecificTransformType

RESOLVED FIXED in mozilla12

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
It seems like the enums enums nsLanguageSpecificTransformType and nsPresContext_CachedBoolPrefType are no longer used and can be removed.
(Assignee)

Comment 1

6 years ago
Created attachment 586313 [details] [diff] [review]
patch
Assignee: nobody → jwatt
Status: NEW → ASSIGNED
Attachment #586313 - Flags: review?(bernd.mielke)

Updated

6 years ago
Attachment #586313 - Flags: review?(bernd.mielke) → review?(bernd_mozilla)

Comment 2

6 years ago
Comment on attachment 586313 [details] [diff] [review]
patch

Review of attachment 586313 [details] [diff] [review]:
-----------------------------------------------------------------

nsLanguageSpecificTransformType is a incomplete removal in bug 458984 
nsWidgetType has not been used since its introduction
Attachment #586313 - Flags: review?(bernd_mozilla) → review+

Comment 3

6 years ago
the bug title indicates that you want to remove nsPresContext_CachedBoolPrefType  too but thats not part of the patch
(Assignee)

Comment 4

6 years ago
Sorry, I meant nsWidgetType, not nsPresContext_CachedBoolPrefType. The patch is correct.

I ran the patch through Try to double check that there weren't any build failures due to the enums being used, hidden behind some macros or something:

https://tbpl.mozilla.org/?tree=Try&rev=bc558a25e5a6

Sorry about getting your email address wrong. You might want to correct it on https://wiki.mozilla.org/Modules/Core to the one you prefer.
Summary: Kill unused enums nsLanguageSpecificTransformType and nsPresContext_CachedBoolPrefType → Kill unused enums nsWidgetType and nsLanguageSpecificTransformType
https://hg.mozilla.org/mozilla-central/rev/ce914679955e (from inbound merge)
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.