715769 - Kill unused enums nsWidgetType and nsLanguageSpecificTransformType

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jonathan Watt [:jwatt]]

It seems like the enums enums nsLanguageSpecificTransformType and nsPresContext_CachedBoolPrefType are no longer used and can be removed.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Bernd]

Comment on attachment 586313 [details] [diff] [review]
patch

Review of attachment 586313 [details] [diff] [review]:
-----------------------------------------------------------------

nsLanguageSpecificTransformType is a incomplete removal in bug 458984 
nsWidgetType has not been used since its introduction

Comment 3

[Bernd]

the bug title indicates that you want to remove nsPresContext_CachedBoolPrefType  too but thats not part of the patch

Comment 4

[Jonathan Watt [:jwatt]]

Sorry, I meant nsWidgetType, not nsPresContext_CachedBoolPrefType. The patch is correct.

I ran the patch through Try to double check that there weren't any build failures due to the enums being used, hidden behind some macros or something:

https://tbpl.mozilla.org/?tree=Try&rev=bc558a25e5a6

Sorry about getting your email address wrong. You might want to correct it on https://wiki.mozilla.org/Modules/Core to the one you prefer.

Comment 5

[Justin Wood (:Callek)]

https://hg.mozilla.org/mozilla-central/rev/ce914679955e (from inbound merge)