Last Comment Bug 715769 - Kill unused enums nsWidgetType and nsLanguageSpecificTransformType
: Kill unused enums nsWidgetType and nsLanguageSpecificTransformType
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla12
Assigned To: Jonathan Watt [:jwatt]
: Jet Villegas (:jet)
Depends on:
  Show dependency treegraph
Reported: 2012-01-05 18:42 PST by Jonathan Watt [:jwatt]
Modified: 2012-01-16 20:02 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (1.08 KB, patch)
2012-01-05 18:44 PST, Jonathan Watt [:jwatt]
bernd_mozilla: review+
Details | Diff | Splinter Review

Description User image Jonathan Watt [:jwatt] 2012-01-05 18:42:54 PST
It seems like the enums enums nsLanguageSpecificTransformType and nsPresContext_CachedBoolPrefType are no longer used and can be removed.
Comment 1 User image Jonathan Watt [:jwatt] 2012-01-05 18:44:06 PST
Created attachment 586313 [details] [diff] [review]
Comment 2 User image Bernd 2012-01-05 22:46:31 PST
Comment on attachment 586313 [details] [diff] [review]

Review of attachment 586313 [details] [diff] [review]:

nsLanguageSpecificTransformType is a incomplete removal in bug 458984 
nsWidgetType has not been used since its introduction
Comment 3 User image Bernd 2012-01-05 22:47:29 PST
the bug title indicates that you want to remove nsPresContext_CachedBoolPrefType  too but thats not part of the patch
Comment 4 User image Jonathan Watt [:jwatt] 2012-01-06 03:24:21 PST
Sorry, I meant nsWidgetType, not nsPresContext_CachedBoolPrefType. The patch is correct.

I ran the patch through Try to double check that there weren't any build failures due to the enums being used, hidden behind some macros or something:

Sorry about getting your email address wrong. You might want to correct it on to the one you prefer.
Comment 5 User image Justin Wood (:Callek) 2012-01-16 20:02:25 PST (from inbound merge)

Note You need to log in before you can comment on or make changes to this bug.