Closed
Bug 715769
Opened 13 years ago
Closed 12 years ago
Kill unused enums nsWidgetType and nsLanguageSpecificTransformType
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file)
|
1.08 KB,
patch
|
bernd_mozilla
:
review+
|
Details | Diff | Splinter Review |
It seems like the enums enums nsLanguageSpecificTransformType and nsPresContext_CachedBoolPrefType are no longer used and can be removed.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #586313 -
Flags: review?(bernd.mielke) → review?(bernd_mozilla)
Comment on attachment 586313 [details] [diff] [review] patch Review of attachment 586313 [details] [diff] [review]: ----------------------------------------------------------------- nsLanguageSpecificTransformType is a incomplete removal in bug 458984 nsWidgetType has not been used since its introduction
Attachment #586313 -
Flags: review?(bernd_mozilla) → review+
the bug title indicates that you want to remove nsPresContext_CachedBoolPrefType too but thats not part of the patch
|
|
Assignee | |
Comment 4•13 years ago
|
||
Sorry, I meant nsWidgetType, not nsPresContext_CachedBoolPrefType. The patch is correct. I ran the patch through Try to double check that there weren't any build failures due to the enums being used, hidden behind some macros or something: https://tbpl.mozilla.org/?tree=Try&rev=bc558a25e5a6 Sorry about getting your email address wrong. You might want to correct it on https://wiki.mozilla.org/Modules/Core to the one you prefer.
Summary: Kill unused enums nsLanguageSpecificTransformType and nsPresContext_CachedBoolPrefType → Kill unused enums nsWidgetType and nsLanguageSpecificTransformType
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ce914679955e (from inbound merge)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•