715776 - Stop shipping import libraries for our DLLs in the Gecko SDK

Status: NEW

(Firefox Build System :: General, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

We ship import libraries for DLLs like xul, mozjs, mozalloc, etc.  We should stop.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 2

[Benjamin Smedberg]

What's the motivation for this? One of the points of the SDK is to have import libraries for libxul/mozjs/nss because binary components sometimes use them. We should continue to do this as long as we want to allow binary components at all.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

To stop binary components from using libxul/mozjs.  See bug 715693 for some examples of the problems.

Comment 4

[Benjamin Smedberg]

Comment on attachment 586392 [details] [diff] [review]
Patch

if we're going to support binary components at all (which is something we've said we want to continue to support), then they need to be able to link against libxul. Maybe not sqlite or mozjs (see comment in bug 715693), but this is a too-farreaching change.

Comment 5

[[e-mail]]

(In reply to Benjamin Smedberg from comment #2)
> What's the motivation for this? One of the points of the SDK is to have
> import libraries for libxul/mozjs/nss because binary components sometimes
> use them.
Sometimes involuntarily; some headers refer (I think) to JS_Assert for example.

Comment 6

[Mike Hommey [:glandium]]

mozilla/Assertions.h does that, and that really should be changed. But note that JS_Assert is a public API.