Closed
Bug 715809
Opened 13 years ago
Closed 12 years ago
AppCache should accept manifests served with non-standard mime types
Categories
(Core :: Networking: Cache, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: bent.mozilla, Assigned: mayhemer)
References
Details
Attachments
(1 file, 1 obsolete file)
4.75 KB,
patch
|
sicking
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-b2g18+
mayhemer
:
checkin+
|
Details | Diff | Splinter Review |
Apparently this is hard for some web hosting customers or something. No real reason to restrict this as far as I can tell.
Attachment #586345 -
Flags: review?(jonas)
Assignee | ||
Comment 1•13 years ago
|
||
As reported in bug 721655, the spec has changed [1], so the patch for me is clearly an r+.
[1] http://html5.org/tools/web-apps-tracker?from=6919&to=6920
Attachment #586345 -
Flags: review?(jonas) → review+
Reporter | ||
Comment 3•13 years ago
|
||
Comment 4•13 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/ea2f8a85e0ed, rather quite orange.
Assignee | ||
Comment 5•13 years ago
|
||
I believe we have tests that check the correctness of the mime type. Should be removed along with the code.
Assignee | ||
Comment 7•13 years ago
|
||
Any progress here??
Crap, i thought this had landed. Yes, we should definitely do this for FF15
Assignee | ||
Comment 9•12 years ago
|
||
Are you chasing the price for the longest time waiting patch to land? :)
Reporter | ||
Comment 10•12 years ago
|
||
Comment on attachment 586345 [details] [diff] [review]
Patch, v1
This patch is correct but tests are totally borked by it. We need to investigate the test failures before this can land and I don't have time currently.
Attachment #586345 -
Flags: review+
Assignee | ||
Comment 11•12 years ago
|
||
We should land this tiny change at last.
Stealing the bug.
Assignee: bent.mozilla → honzab.moz
Assignee | ||
Comment 12•12 years ago
|
||
Attachment #586345 -
Attachment is obsolete: true
Attachment #695197 -
Flags: review?(jonas)
Attachment #695197 -
Flags: review?(jonas) → review+
Assignee | ||
Comment 13•12 years ago
|
||
Comment on attachment 695197 [details] [diff] [review]
v2
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0cda99c4087
Attachment #695197 -
Flags: checkin+
Comment 14•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Comment 15•12 years ago
|
||
Honza - Would this be worth nominating for b2g18? This would resolve an annoying marketplace hosted app issue you probably saw that we have hosted apps getting submitted with appcache manifests with an incorrect mime type.
Assignee | ||
Comment 16•12 years ago
|
||
Comment on attachment 695197 [details] [diff] [review]
v2
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined:
Testing completed:
Risk to taking this patch (and alternatives if risky):
String or UUID changes made by this patch:
Attachment #695197 -
Flags: approval-mozilla-b2g18?
Assignee | ||
Comment 17•12 years ago
|
||
[Approval Request Comment]
Bug caused by (feature/regressing bug #): none
User impact if declined: since the offline app spec for a long time doesn't require the mime type, lots of developers don't add it on the server, so we will fail to load offline caches for potentially important 3rd party web applications leading to bad user experience and putting additional and not necessary effort to our web developers as well as 3rd party developers
Testing completed: just landed on m-c
Risk to taking this patch (and alternatives if risky): *cold zero*
String or UUID changes made by this patch: none
Comment 18•12 years ago
|
||
Comment on attachment 695197 [details] [diff] [review]
v2
[Triage Comment]
Given the risk/reward here, let's land on Aurora 19 and B2G18.
Attachment #695197 -
Flags: approval-mozilla-b2g18?
Attachment #695197 -
Flags: approval-mozilla-b2g18+
Attachment #695197 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 19•12 years ago
|
||
Please don't forget to uplift this to the b2g18 branch.
Comment 22•12 years ago
|
||
(In reply to Jonas Sicking (:sicking) from comment #21)
> Please don't forget to uplift this to the b2g18 branch.
Isn't that what comment 19 did? Looks like the patch was landed on Aurora and b2g 18 in that comment.
Ah, indeed! But the flags weren't updated appropriately. Thanks for landing!
status-b2g18:
--- → fixed
status-firefox19:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•