Last Comment Bug 715822 - OGL CleanupResources should cleanup Texture resources too
: OGL CleanupResources should cleanup Texture resources too
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: mozilla12
Assigned To: Oleg Romashin (:romaxa)
:
Mentors:
Depends on: 793604
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-05 22:45 PST by Oleg Romashin (:romaxa)
Modified: 2012-09-24 00:32 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Cleanup texture resources (6.35 KB, patch)
2012-01-13 23:26 PST, Oleg Romashin (:romaxa)
matt.woodrow: review+
Details | Diff | Splinter Review
Minor modification for reftests (Null check for root layer) (9.41 KB, patch)
2012-01-16 00:27 PST, Oleg Romashin (:romaxa)
no flags Details | Diff | Splinter Review

Description Oleg Romashin (:romaxa) 2012-01-05 22:45:56 PST
On maemo we found that it is better to simply cleanup LayerManagerOGL resources when browser goes to background, and call Initialize() again when it comes to foreground. (instead of LayerManager switch HW->SW which has some problems with ShadowLayers).

It works mostly fine, but we should also cleanup Texture based resources which are keeping reference to GLContext (invalid after CleanupResources call) and later might crash.
Comment 1 Oleg Romashin (:romaxa) 2012-01-13 23:26:44 PST
Created attachment 588605 [details] [diff] [review]
Cleanup texture resources

This should cleanup most of resources.
Comment 2 Oleg Romashin (:romaxa) 2012-01-16 00:27:10 PST
Created attachment 588824 [details] [diff] [review]
Minor modification for reftests (Null check for root layer)
Comment 3 Justin Wood (:Callek) 2012-01-16 19:41:04 PST
https://hg.mozilla.org/mozilla-central/rev/797896e68634 (merge from inbound)

Note You need to log in before you can comment on or make changes to this bug.