Closed
Bug 715849
Opened 13 years ago
Closed 13 years ago
yasm and GNU as should add debug flag if MOZ_DEBUG_SYMBOLS=1
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla13
People
(Reporter: m_kato, Assigned: m_kato)
Details
Attachments
(1 file, 1 obsolete file)
|
4.53 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
yasm supports dwarf2 debug format
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #586756 -
Flags: review?(khuey)
Comment on attachment 586756 [details] [diff] [review]
fix
> ifdef MOZ_DEBUG
>+ ifeq ($(AS),yasm)
>+ ASFLAGS += -g $(_YASM_DEBUG_FORMAT)
>+ else
>+ ASFLAGS += $(MOZ_DEBUG_FLAGS)
>+ endif
> _DEBUG_CFLAGS += $(MOZ_DEBUG_ENABLE_DEFS) $(MOZ_DEBUG_FLAGS)
> _DEBUG_LDFLAGS += $(MOZ_DEBUG_LDFLAGS)
> XULPPFLAGS += $(MOZ_DEBUG_ENABLE_DEFS)
> else
> _DEBUG_CFLAGS += $(MOZ_DEBUG_DISABLE_DEFS)
> XULPPFLAGS += $(MOZ_DEBUG_DISABLE_DEFS)
> ifdef MOZ_DEBUG_SYMBOLS
>+ ifeq ($(AS),yasm)
>+ ASFLAGS += -g $(_YASM_DEBUG_FORMAT)
>+ else
>+ ASFLAGS += $(MOZ_DEBUG_FLAGS)
>+ endif
> _DEBUG_CFLAGS += $(MOZ_DEBUG_FLAGS)
> _DEBUG_LDFLAGS += $(MOZ_DEBUG_LDFLAGS)
> endif
> endif
Lets avoid duplicating this logic. I think you can just move the ifdef MOZ_DEBUG_SYMBOLS block out of the ifdef MOZ_DEBUG conditional.
Attachment #586756 -
Flags: review?(khuey) → review-
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #586756 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•13 years ago
|
Attachment #592088 -
Flags: review?(khuey)
Attachment #592088 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Whiteboard: [inbound]
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla13
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•