715849 - yasm and GNU as should add debug flag if MOZ_DEBUG_SYMBOLS=1

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Makoto Kato [:m_kato] (PTO until 5/6)]

yasm supports dwarf2 debug format

Comment 1

[Makoto Kato [:m_kato] (PTO until 5/6)]

Attachment: fix

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 586756 [details] [diff] [review]
fix

> ifdef MOZ_DEBUG
>+  ifeq ($(AS),yasm)
>+    ASFLAGS += -g $(_YASM_DEBUG_FORMAT)
>+  else
>+    ASFLAGS += $(MOZ_DEBUG_FLAGS)
>+  endif
>   _DEBUG_CFLAGS += $(MOZ_DEBUG_ENABLE_DEFS) $(MOZ_DEBUG_FLAGS)
>   _DEBUG_LDFLAGS += $(MOZ_DEBUG_LDFLAGS)
>   XULPPFLAGS += $(MOZ_DEBUG_ENABLE_DEFS)
> else
>   _DEBUG_CFLAGS += $(MOZ_DEBUG_DISABLE_DEFS)
>   XULPPFLAGS += $(MOZ_DEBUG_DISABLE_DEFS)
>   ifdef MOZ_DEBUG_SYMBOLS
>+    ifeq ($(AS),yasm)
>+      ASFLAGS += -g $(_YASM_DEBUG_FORMAT)
>+    else
>+      ASFLAGS += $(MOZ_DEBUG_FLAGS)
>+    endif
>     _DEBUG_CFLAGS += $(MOZ_DEBUG_FLAGS)
>     _DEBUG_LDFLAGS += $(MOZ_DEBUG_LDFLAGS)
>   endif
> endif

Lets avoid duplicating this logic.  I think you can just move the ifdef MOZ_DEBUG_SYMBOLS block out of the ifdef MOZ_DEBUG conditional.

Comment 3

[Makoto Kato [:m_kato] (PTO until 5/6)]

Attachment: fix v2

Comment 4

[Makoto Kato [:m_kato] (PTO until 5/6)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5620daafb931

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/5620daafb931