The default bug view has changed. See this FAQ.

yasm and GNU as should add debug flag if MOZ_DEBUG_SYMBOLS=1

RESOLVED FIXED in mozilla13

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla13
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
yasm supports dwarf2 debug format
(Assignee)

Comment 1

5 years ago
Created attachment 586756 [details] [diff] [review]
fix
Attachment #586756 - Flags: review?(khuey)
Comment on attachment 586756 [details] [diff] [review]
fix

> ifdef MOZ_DEBUG
>+  ifeq ($(AS),yasm)
>+    ASFLAGS += -g $(_YASM_DEBUG_FORMAT)
>+  else
>+    ASFLAGS += $(MOZ_DEBUG_FLAGS)
>+  endif
>   _DEBUG_CFLAGS += $(MOZ_DEBUG_ENABLE_DEFS) $(MOZ_DEBUG_FLAGS)
>   _DEBUG_LDFLAGS += $(MOZ_DEBUG_LDFLAGS)
>   XULPPFLAGS += $(MOZ_DEBUG_ENABLE_DEFS)
> else
>   _DEBUG_CFLAGS += $(MOZ_DEBUG_DISABLE_DEFS)
>   XULPPFLAGS += $(MOZ_DEBUG_DISABLE_DEFS)
>   ifdef MOZ_DEBUG_SYMBOLS
>+    ifeq ($(AS),yasm)
>+      ASFLAGS += -g $(_YASM_DEBUG_FORMAT)
>+    else
>+      ASFLAGS += $(MOZ_DEBUG_FLAGS)
>+    endif
>     _DEBUG_CFLAGS += $(MOZ_DEBUG_FLAGS)
>     _DEBUG_LDFLAGS += $(MOZ_DEBUG_LDFLAGS)
>   endif
> endif

Lets avoid duplicating this logic.  I think you can just move the ifdef MOZ_DEBUG_SYMBOLS block out of the ifdef MOZ_DEBUG conditional.
Attachment #586756 - Flags: review?(khuey) → review-
(Assignee)

Comment 3

5 years ago
Created attachment 592088 [details] [diff] [review]
fix v2
Attachment #586756 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #592088 - Flags: review?(khuey)
Attachment #592088 - Flags: review?(khuey) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5620daafb931
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/5620daafb931
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.