Last Comment Bug 715849 - yasm and GNU as should add debug flag if MOZ_DEBUG_SYMBOLS=1
: yasm and GNU as should add debug flag if MOZ_DEBUG_SYMBOLS=1
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All Linux
: -- normal (vote)
: mozilla13
Assigned To: Makoto Kato [:m_kato]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-06 03:44 PST by Makoto Kato [:m_kato]
Modified: 2012-02-07 15:02 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (4.17 KB, patch)
2012-01-07 21:11 PST, Makoto Kato [:m_kato]
khuey: review-
Details | Diff | Review
fix v2 (4.53 KB, patch)
2012-01-27 02:42 PST, Makoto Kato [:m_kato]
khuey: review+
Details | Diff | Review

Description Makoto Kato [:m_kato] 2012-01-06 03:44:04 PST
yasm supports dwarf2 debug format
Comment 1 Makoto Kato [:m_kato] 2012-01-07 21:11:58 PST
Created attachment 586756 [details] [diff] [review]
fix
Comment 2 Kyle Huey [:khuey] (khuey@mozilla.com) 2012-01-10 23:33:07 PST
Comment on attachment 586756 [details] [diff] [review]
fix

> ifdef MOZ_DEBUG
>+  ifeq ($(AS),yasm)
>+    ASFLAGS += -g $(_YASM_DEBUG_FORMAT)
>+  else
>+    ASFLAGS += $(MOZ_DEBUG_FLAGS)
>+  endif
>   _DEBUG_CFLAGS += $(MOZ_DEBUG_ENABLE_DEFS) $(MOZ_DEBUG_FLAGS)
>   _DEBUG_LDFLAGS += $(MOZ_DEBUG_LDFLAGS)
>   XULPPFLAGS += $(MOZ_DEBUG_ENABLE_DEFS)
> else
>   _DEBUG_CFLAGS += $(MOZ_DEBUG_DISABLE_DEFS)
>   XULPPFLAGS += $(MOZ_DEBUG_DISABLE_DEFS)
>   ifdef MOZ_DEBUG_SYMBOLS
>+    ifeq ($(AS),yasm)
>+      ASFLAGS += -g $(_YASM_DEBUG_FORMAT)
>+    else
>+      ASFLAGS += $(MOZ_DEBUG_FLAGS)
>+    endif
>     _DEBUG_CFLAGS += $(MOZ_DEBUG_FLAGS)
>     _DEBUG_LDFLAGS += $(MOZ_DEBUG_LDFLAGS)
>   endif
> endif

Lets avoid duplicating this logic.  I think you can just move the ifdef MOZ_DEBUG_SYMBOLS block out of the ifdef MOZ_DEBUG conditional.
Comment 3 Makoto Kato [:m_kato] 2012-01-27 02:42:22 PST
Created attachment 592088 [details] [diff] [review]
fix v2
Comment 5 Marco Bonardo [::mak] 2012-02-07 15:02:24 PST
https://hg.mozilla.org/mozilla-central/rev/5620daafb931

Note You need to log in before you can comment on or make changes to this bug.