Last Comment Bug 715887 - Rename "Properties" to "Computed" in the Style sidebar
: Rename "Properties" to "Computed" in the Style sidebar
Status: RESOLVED FIXED
[computedview]
:
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: Trunk
: x86 All
: -- normal (vote)
: Firefox 12
Assigned To: Paul Rouget [:paul]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-06 07:09 PST by Paul Rouget [:paul]
Modified: 2012-02-20 03:44 PST (History)
8 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v1 (2.60 KB, patch)
2012-01-07 13:53 PST, Paul Rouget [:paul]
rcampbell: review+
Details | Diff | Splinter Review
patch v1.1 (2.72 KB, patch)
2012-01-09 08:46 PST, Paul Rouget [:paul]
no flags Details | Diff | Splinter Review

Description Paul Rouget [:paul] 2012-01-06 07:09:16 PST
Apparently, "Properties" is not well understood. "Computed" would make more sense.
Comment 1 Paul Rouget [:paul] 2012-01-07 13:53:50 PST
Created attachment 586728 [details] [diff] [review]
patch v1
Comment 2 Rob Campbell [:rc] (:robcee) 2012-01-09 07:23:27 PST
Really? "Properties" is a plural noun. "Computed" is an adjective (or a verb in the past tense). I know other tools refer to "computed styles" but the word computed alone is not a great UI fixture.

...

Talked with Paul a bit and agree that there is no great descriptive word for these Computed Styles. For the sake of brevity, and consistency with other developer tools, Computed is probably what we'll need to go with.
Comment 3 Rob Campbell [:rc] (:robcee) 2012-01-09 07:34:43 PST
Comment on attachment 586728 [details] [diff] [review]
patch v1

could you add a LOCALIZATION NOTE describing what "Computed" is? That it refers to the computed styles of the currently selected node in the Page Inspector's Style sidebar.

Thanks!
Comment 4 Paul Rouget [:paul] 2012-01-09 08:46:12 PST
Created attachment 587013 [details] [diff] [review]
patch v1.1
Comment 5 Paul Rouget [:paul] 2012-01-09 09:01:03 PST
(we will need this in Firefox Beta 10)
Comment 6 Rob Campbell [:rc] (:robcee) 2012-01-14 09:57:43 PST
https://hg.mozilla.org/integration/fx-team/rev/ac68e86a346e
Comment 7 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-01-16 02:29:09 PST
https://hg.mozilla.org/mozilla-central/rev/ac68e86a346e
Comment 8 Francesco Lodolo [:flod] 2012-01-18 10:57:22 PST
Why didn't you change also the tooltip key name with the other two keys?

Honestly I have big problems understanding what "Computed" stands for, could you please explain it with some more detail?

> "Computed" refers to the Computed Style of the element."
Comment 9 Paul Rouget [:paul] 2012-01-18 11:05:56 PST
(In reply to flod (Francesco Lodolo) from comment #8)
> Why didn't you change also the tooltip key name with the other two keys?
> 
> Honestly I have big problems understanding what "Computed" stands for, could
> you please explain it with some more detail?
> 
> > "Computed" refers to the Computed Style of the element."

From MDN: https://developer.mozilla.org/en/DOM/window.getComputedStyle
Computed styles are the final used values of all the CSS properties of an element.

It refers to this documentation: Used Value
https://developer.mozilla.org/en/CSS/used_value

Maybe "Used Values" is better than "Computed".

I think "Computed Style" is what web devs understand the best.
Comment 10 Gion-Andri Cantieni [:gion-andri] 2012-02-19 04:53:28 PST
I think change the value of 'style.highlighter.button.tooltip' and not renamining will cause some trouble for localization!
Comment 11 Paul Rouget [:paul] 2012-02-20 02:48:22 PST
(In reply to Gion-Andri Cantieni from comment #10)
> I think change the value of 'style.highlighter.button.tooltip' and not
> renamining will cause some trouble for localization!

Can you please file a bug for that?
Comment 12 Gion-Andri Cantieni [:gion-andri] 2012-02-20 03:33:16 PST
(In reply to Paul Rouget [:paul] from comment #11)
> Can you please file a bug for that?

I opend bug 728833.
Comment 13 Francesco Lodolo [:flod] 2012-02-20 03:34:52 PST
Honestly I believe that's too late for that (don't do it on Aurora!)
Comment 14 Axel Hecht [pto-Aug-30][:Pike] 2012-02-20 03:44:02 PST
We can still do it on central, and take that update with the next cycle.

Note You need to log in before you can comment on or make changes to this bug.