Rename "Properties" to "Computed" in the Style sidebar

RESOLVED FIXED in Firefox 12

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: paul, Assigned: paul)

Tracking

Trunk
Firefox 12
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [computedview])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Apparently, "Properties" is not well understood. "Computed" would make more sense.
Whiteboard: [styleinspector]
(Assignee)

Updated

6 years ago
Assignee: nobody → paul
(Assignee)

Comment 1

6 years ago
Created attachment 586728 [details] [diff] [review]
patch v1
(Assignee)

Updated

6 years ago
Attachment #586728 - Flags: review?(rcampbell)
Really? "Properties" is a plural noun. "Computed" is an adjective (or a verb in the past tense). I know other tools refer to "computed styles" but the word computed alone is not a great UI fixture.

...

Talked with Paul a bit and agree that there is no great descriptive word for these Computed Styles. For the sake of brevity, and consistency with other developer tools, Computed is probably what we'll need to go with.
Comment on attachment 586728 [details] [diff] [review]
patch v1

could you add a LOCALIZATION NOTE describing what "Computed" is? That it refers to the computed styles of the currently selected node in the Page Inspector's Style sidebar.

Thanks!
Attachment #586728 - Flags: review?(rcampbell) → review+
(Assignee)

Comment 4

6 years ago
Created attachment 587013 [details] [diff] [review]
patch v1.1
(Assignee)

Updated

6 years ago
Attachment #586728 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Whiteboard: [styleinspector] → [styleinspector][land-in-fx-team]
(Assignee)

Comment 5

6 years ago
(we will need this in Firefox Beta 10)
Whiteboard: [styleinspector][land-in-fx-team] → [computedview][land-in-fx-team]
Status: NEW → ASSIGNED
https://hg.mozilla.org/integration/fx-team/rev/ac68e86a346e
Whiteboard: [computedview][land-in-fx-team] → [computedview][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/ac68e86a346e
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [computedview][fixed-in-fx-team] → [computedview]
Target Milestone: --- → Firefox 12
Why didn't you change also the tooltip key name with the other two keys?

Honestly I have big problems understanding what "Computed" stands for, could you please explain it with some more detail?

> "Computed" refers to the Computed Style of the element."
(Assignee)

Comment 9

6 years ago
(In reply to flod (Francesco Lodolo) from comment #8)
> Why didn't you change also the tooltip key name with the other two keys?
> 
> Honestly I have big problems understanding what "Computed" stands for, could
> you please explain it with some more detail?
> 
> > "Computed" refers to the Computed Style of the element."

From MDN: https://developer.mozilla.org/en/DOM/window.getComputedStyle
Computed styles are the final used values of all the CSS properties of an element.

It refers to this documentation: Used Value
https://developer.mozilla.org/en/CSS/used_value

Maybe "Used Values" is better than "Computed".

I think "Computed Style" is what web devs understand the best.
I think change the value of 'style.highlighter.button.tooltip' and not renamining will cause some trouble for localization!
(Assignee)

Comment 11

6 years ago
(In reply to Gion-Andri Cantieni from comment #10)
> I think change the value of 'style.highlighter.button.tooltip' and not
> renamining will cause some trouble for localization!

Can you please file a bug for that?
(In reply to Paul Rouget [:paul] from comment #11)
> Can you please file a bug for that?

I opend bug 728833.
Honestly I believe that's too late for that (don't do it on Aurora!)

Comment 14

6 years ago
We can still do it on central, and take that update with the next cycle.
You need to log in before you can comment on or make changes to this bug.