Closed
Bug 715887
Opened 13 years ago
Closed 13 years ago
Rename "Properties" to "Computed" in the Style sidebar
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 12
People
(Reporter: paul, Assigned: paul)
Details
(Whiteboard: [computedview])
Attachments
(1 file, 1 obsolete file)
2.72 KB,
patch
|
Details | Diff | Splinter Review |
Apparently, "Properties" is not well understood. "Computed" would make more sense.
Updated•13 years ago
|
Whiteboard: [styleinspector]
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → paul
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Attachment #586728 -
Flags: review?(rcampbell)
Comment 2•13 years ago
|
||
Really? "Properties" is a plural noun. "Computed" is an adjective (or a verb in the past tense). I know other tools refer to "computed styles" but the word computed alone is not a great UI fixture.
...
Talked with Paul a bit and agree that there is no great descriptive word for these Computed Styles. For the sake of brevity, and consistency with other developer tools, Computed is probably what we'll need to go with.
Comment 3•13 years ago
|
||
Comment on attachment 586728 [details] [diff] [review]
patch v1
could you add a LOCALIZATION NOTE describing what "Computed" is? That it refers to the computed styles of the currently selected node in the Page Inspector's Style sidebar.
Thanks!
Attachment #586728 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Attachment #586728 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Whiteboard: [styleinspector] → [styleinspector][land-in-fx-team]
Assignee | ||
Comment 5•13 years ago
|
||
(we will need this in Firefox Beta 10)
Updated•13 years ago
|
Whiteboard: [styleinspector][land-in-fx-team] → [computedview][land-in-fx-team]
Updated•13 years ago
|
Status: NEW → ASSIGNED
Comment 6•13 years ago
|
||
Whiteboard: [computedview][land-in-fx-team] → [computedview][fixed-in-fx-team]
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [computedview][fixed-in-fx-team] → [computedview]
Target Milestone: --- → Firefox 12
Comment 8•13 years ago
|
||
Why didn't you change also the tooltip key name with the other two keys?
Honestly I have big problems understanding what "Computed" stands for, could you please explain it with some more detail?
> "Computed" refers to the Computed Style of the element."
Assignee | ||
Comment 9•13 years ago
|
||
(In reply to flod (Francesco Lodolo) from comment #8)
> Why didn't you change also the tooltip key name with the other two keys?
>
> Honestly I have big problems understanding what "Computed" stands for, could
> you please explain it with some more detail?
>
> > "Computed" refers to the Computed Style of the element."
From MDN: https://developer.mozilla.org/en/DOM/window.getComputedStyle
Computed styles are the final used values of all the CSS properties of an element.
It refers to this documentation: Used Value
https://developer.mozilla.org/en/CSS/used_value
Maybe "Used Values" is better than "Computed".
I think "Computed Style" is what web devs understand the best.
Comment 10•13 years ago
|
||
I think change the value of 'style.highlighter.button.tooltip' and not renamining will cause some trouble for localization!
Assignee | ||
Comment 11•13 years ago
|
||
(In reply to Gion-Andri Cantieni from comment #10)
> I think change the value of 'style.highlighter.button.tooltip' and not
> renamining will cause some trouble for localization!
Can you please file a bug for that?
Comment 12•13 years ago
|
||
(In reply to Paul Rouget [:paul] from comment #11)
> Can you please file a bug for that?
I opend bug 728833.
Comment 13•13 years ago
|
||
Honestly I believe that's too late for that (don't do it on Aurora!)
Comment 14•13 years ago
|
||
We can still do it on central, and take that update with the next cycle.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•