715889 - Form Assist Autocomplete called on full-screen VKB

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Aaron Train [:aaronmt]]

Form assistant for autocomplete should not be used in full-screen keyboard since it can not be seen. It seems like a lot of calls to it are made .

STR:

1. http://mail.yahoo.com
2. Rotate to landscape
3. Begin typing in the "Yahoo! ID" field

I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete

--
Samsung Nexus S (Android 4.0.3)
Mozilla/5.0 (Andorid; Linux armv7l; rv:12.0a1) Gecko/20120106 Firefox/12.0a1 Fennec/12.0a1

Comment 1

[:Margaret Leibovic]

I can take this, since I'm working on this code right now.

Comment 2

[:Margaret Leibovic]

(In reply to Aaron Train [:aaronmt] from comment #0)
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete

These messages actually don't mean the popup is being shown - we send a message to java with suggestions whenever text is entered in an input box. Then in GeckoApp (after we get this FormAssist:AutoComplete message), we decide if we should show the popup or not based on the size of the suggestions array. Initially, we didn't send a message if there were no suggestions, but then that made it difficult to hide the popup once there were no suggestions left.

I still think you're right that we should make sure we're not doing unnecessary work in fullscreen keyboard mode, but this won't change these messages :)

Comment 3

[:Margaret Leibovic]

Attachment: patch

To test, I added a log statement in AutoCompletePopup.show, and Aaron was right that we were creating/updating the layout in fullscreen VKB. This fixes that.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 587557 [details] [diff] [review]
patch

I suppose putting the check _inside_ the runnable is the proper thing to do, given the magic of threads.

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f78cc74ee589

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f78cc74ee589

Comment 7

[:Margaret Leibovic]

Comment on attachment 587557 [details] [diff] [review]
patch

[Approval Request Comment]
User impact if declined: potential performance loss
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): none

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 587557 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approving for Aurora.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5ca790e6be81

Comment 10

[Aaron Train [:aaronmt]]

Verified on M-A & M-C
Galaxy Nexus (Android 4.0.3)

20120126053754
http://hg.mozilla.org/releases/mozilla-aurora/rev/9d5ede8cb11a

20120126031113
http://hg.mozilla.org/mozilla-central/rev/402b394b6623