Closed Bug 715889 Opened 8 years ago Closed 8 years ago

Form Assist Autocomplete called on full-screen VKB

Categories

(Firefox for Android :: General, defect, P3)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 12
Tracking Status
firefox11 --- verified
firefox12 --- verified
fennec 11+ ---

People

(Reporter: aaronmt, Assigned: Margaret)

Details

(Whiteboard: [testday-20120106])

Attachments

(1 file)

Form assistant for autocomplete should not be used in full-screen keyboard since it can not be seen. It seems like a lot of calls to it are made .

STR:

1. http://mail.yahoo.com
2. Rotate to landscape
3. Begin typing in the "Yahoo! ID" field

I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
I/GeckoApp( 2284): Got message: FormAssist:AutoComplete

--
Samsung Nexus S (Android 4.0.3)
Mozilla/5.0 (Andorid; Linux armv7l; rv:12.0a1) Gecko/20120106 Firefox/12.0a1 Fennec/12.0a1
Whiteboard: [testday-20120106]
Assignee: nobody → wjohnston
tracking-fennec: --- → 11+
Priority: -- → P3
I can take this, since I'm working on this code right now.
Assignee: wjohnston → margaret.leibovic
(In reply to Aaron Train [:aaronmt] from comment #0)
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete
> I/GeckoApp( 2284): Got message: FormAssist:AutoComplete

These messages actually don't mean the popup is being shown - we send a message to java with suggestions whenever text is entered in an input box. Then in GeckoApp (after we get this FormAssist:AutoComplete message), we decide if we should show the popup or not based on the size of the suggestions array. Initially, we didn't send a message if there were no suggestions, but then that made it difficult to hide the popup once there were no suggestions left.

I still think you're right that we should make sure we're not doing unnecessary work in fullscreen keyboard mode, but this won't change these messages :)
Attached patch patchSplinter Review
To test, I added a log statement in AutoCompletePopup.show, and Aaron was right that we were creating/updating the layout in fullscreen VKB. This fixes that.
Attachment #587557 - Flags: review?(mark.finkle)
Comment on attachment 587557 [details] [diff] [review]
patch

I suppose putting the check _inside_ the runnable is the proper thing to do, given the magic of threads.
Attachment #587557 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/f78cc74ee589
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 587557 [details] [diff] [review]
patch

[Approval Request Comment]
User impact if declined: potential performance loss
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): none
Attachment #587557 - Flags: approval-mozilla-aurora?
Comment on attachment 587557 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approving for Aurora.
Attachment #587557 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified on M-A & M-C
Galaxy Nexus (Android 4.0.3)

20120126053754
http://hg.mozilla.org/releases/mozilla-aurora/rev/9d5ede8cb11a

20120126031113
http://hg.mozilla.org/mozilla-central/rev/402b394b6623
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.