715917 - [valgrind] Potential memory problem in google_breakpad::ExceptionHandler::InstallHandlers

Status: NEW

(Toolkit :: Crash Reporting, defect)

Description

[David Dahl :ddahl]

This snippet from a valgrind dump might be a memory bug:

==21501== 8,192 bytes in 1 blocks are definitely lost in loss record 399 of 402
==21501==    at 0x4C29313: malloc (vg_replace_malloc.c:263)
==21501==    by 0x5D0954F: google_breakpad::ExceptionHandler::InstallHandlers() (exception_handler.cc:193)
==21501==    by 0x5D0949E: google_breakpad::ExceptionHandler::Init(std::string const&, int) (exception_handler.cc:172)
==21501==    by 0x5D092D0: google_breakpad::ExceptionHandler::ExceptionHandler(std::string const&, bool (*)(void*), bool (*)(char const*, char const*, void*, bool), void*, bool) (exception_handler.cc:141)
==21501==    by 0x5CFFBDC: CrashReporter::SetExceptionHandler(nsILocalFile*, bool) (nsExceptionHandler.cpp:775)
==21501==    by 0x5CD9854: nsXULAppInfo::SetEnabled(bool) (nsAppRunner.cpp:910)
==21501==    by 0x74A37EC: NS_InvokeByIndex_P (xptcinvoke_x86_64_unix.cpp:195)
==21501==    by 0x6CF25C8: CallMethodHelper::Invoke() (XPCWrappedNative.cpp:2919)
==21501==    by 0x6CF040E: CallMethodHelper::Call() (XPCWrappedNative.cpp:2250)
==21501==    by 0x6CF02A5: XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) (XPCWrappedNative.cpp:2216)
==21501==    by 0x6CF8704: XPCWrappedNative::SetAttribute(XPCCallContext&) (xpcprivate.h:2661)
==21501==    by 0x6CFDAF2: XPC_WN_GetterSetter(JSContext*, unsigned int, JS::Value*) (XPCWrappedNativeJSOps.cpp:1593)
==21501== 

I am a valgrind newbie, so I am not exactly sure if this is a problem - and if it is a duplicate bug report

Comment 1

[David Dahl :ddahl]

The original full dump is here: https://bug665057.bugzilla.mozilla.org/attachment.cgi?id=586432

also,

I found this with a valgrind build running with the patch from bug 665057 and the xpcshell command:

make SOLO_FILE="test_id_service_keypair.js" -C security/manager/ssl/tests/ check-one EXTRA_TEST_ARGS='--debugger=valgrind'