Note: There are a few cases of duplicates in user autocompletion which are being worked on.

pop3 move mail filters with quarantining turned off or download size limit get the resulting message size too big by two bytes

RESOLVED FIXED in Thunderbird 12.0

Status

MailNews Core
Backend
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

Trunk
Thunderbird 12.0
x86_64
Windows 7
Bug Flags:
in-testsuite +

Thunderbird Tracking Flags

(thunderbird12 fixed, thunderbird13 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
If message quarantining is turned off (not the default), pop3 incoming move mail filters get the message size wrong by two bytes too many in the resulting msg hdr. This is relatively harmless, but obviously should be fixed. I suspect this is a flush issue.
(Assignee)

Comment 1

6 years ago
Created attachment 587720 [details] [diff] [review]
proposed fix

I'll try to see if I can come up with a unit test for this.
(Assignee)

Comment 2

6 years ago
Created attachment 588559 [details] [diff] [review]
fix with unit test

This makes sure we flush full messages, and extends the pop3FilterMove test to test that the message is right. In debug builds, we assert, w/o the core change, and I believe in release mode it'll fail as well.
Attachment #587720 - Attachment is obsolete: true
Attachment #588559 - Flags: review?(mbanner)
Attachment #588559 - Flags: review?(mbanner) → review+
(Assignee)

Comment 3

6 years ago
fix checked in - http://hg.mozilla.org/comm-central/rev/986abadfbeb7
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
(Assignee)

Comment 4

5 years ago
Created attachment 611945 [details] [diff] [review]
fix msg download limiting case

We have the exact same issue if message download limit is set. So I'm just always going to flush. Extended unit test to test for this as well.
Attachment #611945 - Flags: review?(mbanner)
Attachment #611945 - Flags: approval-comm-release?
Attachment #611945 - Flags: approval-comm-beta?
(Assignee)

Updated

5 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: pop3 move mail filters with quarantining turned off get the resulting message size too big by two bytes → pop3 move mail filters with quarantining turned off or download size limit get the resulting message size too big by two bytes
Attachment #611945 - Flags: approval-comm-release?
Attachment #611945 - Flags: approval-comm-release+
Attachment #611945 - Flags: approval-comm-beta?
Attachment #611945 - Flags: approval-comm-beta+
Attachment #611945 - Flags: review?(mbanner) → review+
(Assignee)

Comment 5

5 years ago
follow-on fix landed on trunk - http://hg.mozilla.org/comm-central/rev/9843a6596561
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

5 years ago
and backed out and relanded - http://hg.mozilla.org/comm-central/rev/cb2b8fd3f517
Checked into branches:

http://hg.mozilla.org/releases/comm-aurora/rev/9306cdde5483
http://hg.mozilla.org/releases/comm-beta/rev/9bdfa24dedd9
status-thunderbird12: --- → fixed
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.