Closed Bug 715922 Opened 9 years ago Closed 9 years ago

pop3 move mail filters with quarantining turned off or download size limit get the resulting message size too big by two bytes

Categories

(MailNews Core :: Backend, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(thunderbird12 fixed, thunderbird13 fixed)

RESOLVED FIXED
Thunderbird 12.0
Tracking Status
thunderbird12 --- fixed
thunderbird13 --- fixed

People

(Reporter: Bienvenu, Assigned: Bienvenu)

References

Details

Attachments

(2 files, 1 obsolete file)

If message quarantining is turned off (not the default), pop3 incoming move mail filters get the message size wrong by two bytes too many in the resulting msg hdr. This is relatively harmless, but obviously should be fixed. I suspect this is a flush issue.
Attached patch proposed fix (obsolete) — Splinter Review
I'll try to see if I can come up with a unit test for this.
This makes sure we flush full messages, and extends the pop3FilterMove test to test that the message is right. In debug builds, we assert, w/o the core change, and I believe in release mode it'll fail as well.
Attachment #587720 - Attachment is obsolete: true
Attachment #588559 - Flags: review?(mbanner)
Attachment #588559 - Flags: review?(mbanner) → review+
fix checked in - http://hg.mozilla.org/comm-central/rev/986abadfbeb7
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
We have the exact same issue if message download limit is set. So I'm just always going to flush. Extended unit test to test for this as well.
Attachment #611945 - Flags: review?(mbanner)
Attachment #611945 - Flags: approval-comm-release?
Attachment #611945 - Flags: approval-comm-beta?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: pop3 move mail filters with quarantining turned off get the resulting message size too big by two bytes → pop3 move mail filters with quarantining turned off or download size limit get the resulting message size too big by two bytes
Attachment #611945 - Flags: approval-comm-release?
Attachment #611945 - Flags: approval-comm-release+
Attachment #611945 - Flags: approval-comm-beta?
Attachment #611945 - Flags: approval-comm-beta+
Attachment #611945 - Flags: review?(mbanner) → review+
follow-on fix landed on trunk - http://hg.mozilla.org/comm-central/rev/9843a6596561
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
and backed out and relanded - http://hg.mozilla.org/comm-central/rev/cb2b8fd3f517
You need to log in before you can comment on or make changes to this bug.