If message quarantining is turned off (not the default), pop3 incoming move mail filters get the message size wrong by two bytes too many in the resulting msg hdr. This is relatively harmless, but obviously should be fixed. I suspect this is a flush issue.
Created attachment 587720 [details] [diff] [review]
I'll try to see if I can come up with a unit test for this.
Created attachment 588559 [details] [diff] [review]
fix with unit test
This makes sure we flush full messages, and extends the pop3FilterMove test to test that the message is right. In debug builds, we assert, w/o the core change, and I believe in release mode it'll fail as well.
fix checked in - http://hg.mozilla.org/comm-central/rev/986abadfbeb7
Created attachment 611945 [details] [diff] [review]
fix msg download limiting case
We have the exact same issue if message download limit is set. So I'm just always going to flush. Extended unit test to test for this as well.
follow-on fix landed on trunk - http://hg.mozilla.org/comm-central/rev/9843a6596561
and backed out and relanded - http://hg.mozilla.org/comm-central/rev/cb2b8fd3f517
Checked into branches: