Last Comment Bug 715943 - StackFrame marking should not skip its JSFunction
: StackFrame marking should not skip its JSFunction
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
-- normal (vote)
: ---
Assigned To: Terrence Cole [:terrence]
: Jason Orendorff [:jorendorff]
Depends on:
Blocks: 714109
  Show dependency treegraph
Reported: 2012-01-06 10:10 PST by Terrence Cole [:terrence]
Modified: 2012-01-09 10:23 PST (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

v1 (1.31 KB, patch)
2012-01-06 10:10 PST, Terrence Cole [:terrence]
luke: review+
Details | Diff | Splinter Review

Description User image Terrence Cole [:terrence] 2012-01-06 10:10:11 PST
Created attachment 586467 [details] [diff] [review]

Right now, the StackFrame marks script().  When this is a plain function, this returns fun()->script(), meaning that we never explicitly mark fun() and rely on it being rooting in some other fashion.  This is incorrect.
Comment 1 User image Luke Wagner [:luke] 2012-01-06 10:32:07 PST
Comment on attachment 586467 [details] [diff] [review]

Comment 2 User image Terrence Cole [:terrence] 2012-01-06 11:02:38 PST
Comment 3 User image Terrence Cole [:terrence] 2012-01-09 10:23:32 PST

Note You need to log in before you can comment on or make changes to this bug.