71601 - libraries have IS_COMPONENT=1 but export additional functions

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect)

Description

[achimha]

In bug 71558 I'm doing some changes to the OS/2 build system to be more similar
to what Linux does. Previously we exported all public symbols for DLLs that we
created (very ugly). Now we use the IS_COMPONENT flag in the Makefile.in for
each module and if it is set, we only export NSGetModule as to the XPCOM
specification. This works fine, however mailnews breaks this rule in:
/mozilla/mailnews/mime/cthandlers/signstub
/mozilla/mailnews/mime/cthandlers/smimestub
/mozilla/mailnews/mime/cthandlers/vcard
These are configured to be XPCOM modules and yet they require additional
functions to be exported. As a workaround, I have patches their makefiles
(see 71558) to tell our OS/2 build system to export everything despite it is
being marked as XPCOM.
Could you please change your code to not require it to export anything else
besides NSGetModule for IS_COMPONENT=1 libraries?

Comment 1

[hacker formerly known as [e-mail]]

I think this issue may have gone away since those modules were converted to
generic modules (bug 77226).

Comment 2

[Mike Kaply [:mkaply]]

There is still one thing left - xpcom/tests/services/Makefile.in

Once that is gone, we can get rid of this completely.

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Remove HAS_EXTRAEXPORTS from mail

Comment 4

[hacker formerly known as [e-mail]]

Attachment: Turn MyService component into a generic module

Comment 5

[hacker formerly known as [e-mail]]

Doug, can you review the MyService & TestServMgr changes?

Comment 6

[hacker formerly known as [e-mail]]

Comment on attachment 54254 [details] [diff] [review]
Remove HAS_EXTRAEXPORTS from mail

r=cls

Comment 7

[Mike Kaply [:mkaply]]

Makefile changes in.

I'll build the tests on OS/2 tomorrow just for fun.

Comment 8

[Doug Turner (:dougt)]

Comment on attachment 54284 [details] [diff] [review]
Turn MyService component into a generic module

looks fine.

Comment 9

[hacker formerly known as [e-mail]]

Patch checked in.  All of the HAS_EXTRAEXPORTS instances have been fixed.

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

Can someone who builds on OS/2 verify this? Mike, would you do the honors,
please?  Thanks.

Comment 11

[Mike Kaply [:mkaply]]

Works like a charm