Intermittent chrome://mochitests/content/chrome/editor/libeditor/base/tests/test_selection_move_commands.xul | cmd_scrollBottom - got 0, expected -300

RESOLVED FIXED in mozilla18

Status

()

Core
Editor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: emorley, Assigned: vlad)

Tracking

({intermittent-failure})

12 Branch
mozilla18
x86
Mac OS X
intermittent-failure
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=8265070&tree=Firefox
Rev3 MacOSX Leopard 10.5.8 mozilla-central opt test mochitest-other on https://hg.mozilla.org/mozilla-central/rev/d702c3cf4e4a

9916 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/editor/libeditor/base/tests/test_selection_move_commands.xul | cmd_scrollBottom - got 0, expected -300
(Reporter)

Updated

5 years ago
Summary: chrome://mochitests/content/chrome/editor/libIntermittent editor/base/tests/test_selection_move_commands.xul | cmd_scrollBottom - got 0, expected -300 → Intermittent chrome://mochitests/content/chrome/editor/libeditor/base/tests/test_selection_move_commands.xul | cmd_scrollBottom - got 0, expected -300
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Created attachment 588687 [details] [diff] [review]
This should fix it, I think; fixes things for me in the try pushes where I was seeing this a lot
Attachment #588687 - Flags: review?(ehsan)
Assignee: nobody → bzbarsky
Whiteboard: [orange] → [need review][orange]
Pushed as https://hg.mozilla.org/integration/mozilla-inbound/rev/1e0405f18207 in the meantime, because I needed it for something else.
Target Milestone: --- → mozilla12
This merged to m-c:
https://hg.mozilla.org/mozilla-central/rev/1e0405f18207

I'm not resolving the bug for now, though, as it's still pending review - not sure how best to handle that.
I think we should just go ahead and resolve, then file followups if Ehsan has a problem with the patch or reopen if this keeps happening.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment #588687 - Flags: review?(ehsan) → review+
Whiteboard: [need review][orange] → [orange]
Comment hidden (Treeherder Robot)
(Reporter)

Updated

5 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Assignee: bzbarsky → nobody
Comment hidden (Treeherder Robot)
(Assignee)

Comment 18

5 years ago
Created attachment 668161 [details] [diff] [review]
alternate patch, using explicit refresh driver timing

Alternate/different fix -- drive the refreshdriver directly, which is what is doing the scrolling.  This seems to fix this for me in a pretty bulletproof way; ehsan r+'d it over my shoulder.  May also fix bug 752808 and bug 759254.
Assignee: nobody → vladimir
Attachment #668161 - Flags: review+
(Reporter)

Comment 19

5 years ago
https://hg.mozilla.org/mozilla-central/rev/e28ab3e5e961
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: mozilla12 → mozilla18
Keywords: intermittent-failure
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.