The default bug view has changed. See this FAQ.

Move write barriers from jsapi.h to jsfriendapi.h

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

unspecified
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 586543 [details] [diff] [review]
patch

I no longer have much faith left that outside developers will be able to correctly implement write barriers. So this patch moves the API to jsfriendapi.h, and also simplifies it somewhat.

I also changed the SetProto barrier on XPCWrappedNative. Previously, the barrier used the existing tracing code to trace the wrapped native's proto. Now it uses a special write barrier call instead. The reason to do this is that it doesn't require a JSTracer. Requiring the runtime to have a JSTracer for XPConnect barriers is troublesome because of thread safety issues.

Most of these are JSAPI changes for Luke. Also asking for Bobby's review of the XPConnect changes.
Attachment #586543 - Flags: review?(luke)
Attachment #586543 - Flags: review?(bobbyholley+bmo)

Updated

5 years ago
Attachment #586543 - Flags: review?(luke) → review+
Attachment #586543 - Flags: review?(bobbyholley+bmo) → review+
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1d7e7ac1b77
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/b1d7e7ac1b77
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.