716073 - Fix compile warnings

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Richard Newman [:rnewman]]

Current set:

/Users/rnewman/moz/hg/mozilla-central/mobile/android/base/sync/jpake/JPakeClient.java:1063: warning: [cast] redundant cast to int
      secret.append(key.charAt((int) (Math.abs(b) * keylen / 256)));
                               ^
/Users/rnewman/moz/hg/mozilla-central/mobile/android/base/sync/setup/activities/SetupSyncActivity.java:262: warning: [unchecked] unchecked call to put(K,V) as a member of the raw type java.util.HashMap
        jAccount.put(Constants.JSON_KEY_SYNCKEY, synckey);
                    ^
/Users/rnewman/moz/hg/mozilla-central/mobile/android/base/sync/setup/activities/SetupSyncActivity.java:263: warning: [unchecked] unchecked call to put(K,V) as a member of the raw type java.util.HashMap
        jAccount.put(Constants.JSON_KEY_ACCOUNT, username);
                    ^
/Users/rnewman/moz/hg/mozilla-central/mobile/android/base/sync/setup/activities/SetupSyncActivity.java:264: warning: [unchecked] unchecked call to put(K,V) as a member of the raw type java.util.HashMap
        jAccount.put(Constants.JSON_KEY_PASSWORD, password);
                    ^
/Users/rnewman/moz/hg/mozilla-central/mobile/android/base/sync/setup/activities/SetupSyncActivity.java:265: warning: [unchecked] unchecked call to put(K,V) as a member of the raw type java.util.HashMap
        jAccount.put(Constants.JSON_KEY_SERVER, serverUrl);
                    ^
/Users/rnewman/moz/hg/mozilla-central/mobile/android/base/sync/repositories/android/AndroidBrowserHistoryDataAccessor.java:77: warning: [cast] redundant cast to org.json.simple.JSONArray
      JSONArray visits = (JSONArray) rec.visits;
                         ^
/Users/rnewman/moz/hg/mozilla-central/mobile/android/base/sync/repositories/android/AndroidBrowserHistoryRepositorySession.java:96: warning: [cast] redundant cast to long
          fake.put(KEY_DATE, (long) hist.fennecDateVisited - (1 + j));
                             ^
/Users/rnewman/moz/hg/mozilla-central/mobile/android/base/sync/Utils.java:187: warning: [cast] redundant cast to long
    return (long)(decimal * 1000);

Comment 1

[Marina Samuel [:emtwo]]

Resolved: https://github.com/mozilla-services/android-sync/commit/d4010c878568e39290ccc827f96b8c754098569a

Comment 2

[Richard Newman [:rnewman]]

Not complete: need to suppress warnings in jAccount.put.

Comment 3

[Marina Samuel [:emtwo]]

Added suppress warnings:
https://github.com/mozilla-services/android-sync/commit/e79a49e6