Last Comment Bug 716090 - IonMonkey: Invalidate inactive IonScripts
: IonMonkey: Invalidate inactive IonScripts
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: David Anderson [:dvander]
:
Mentors:
Depends on:
Blocks: 677337
  Show dependency treegraph
 
Reported: 2012-01-06 14:39 PST by David Anderson [:dvander]
Modified: 2012-01-09 15:07 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (6.28 KB, patch)
2012-01-06 14:40 PST, David Anderson [:dvander]
cdleary: review+
Details | Diff | Splinter Review

Description David Anderson [:dvander] 2012-01-06 14:39:58 PST
We're failing the following tests because we're missing a few IonScripts during invalidation:
    ion/callgname.js
    ion/setelem-proto.js
    ion/setgname.js
    ion/invalidation/recursive-invalidate.js
Comment 1 David Anderson [:dvander] 2012-01-06 14:40:33 PST
Created attachment 586575 [details] [diff] [review]
fix
Comment 2 Chris Leary [:cdleary] (not checking bugmail) 2012-01-06 15:46:57 PST
Comment on attachment 586575 [details] [diff] [review]
fix

Review of attachment 586575 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/Ion.cpp
@@ +1004,5 @@
>  
>  void
>  ion::Invalidate(JSContext *cx, const Vector<JSScript *> &invalid)
>  {
> +    // Add an invalidation reference to all invalidated IonScripts.

Nit: can we add something like "to indicate to to the traversal which frames have been invalidated"?

Note You need to log in before you can comment on or make changes to this bug.