IonMonkey: Invalidate inactive IonScripts

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dvander, Assigned: dvander)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We're failing the following tests because we're missing a few IonScripts during invalidation:
    ion/callgname.js
    ion/setelem-proto.js
    ion/setgname.js
    ion/invalidation/recursive-invalidate.js
Created attachment 586575 [details] [diff] [review]
fix
Attachment #586575 - Flags: review?(christopher.leary)
Comment on attachment 586575 [details] [diff] [review]
fix

Review of attachment 586575 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/Ion.cpp
@@ +1004,5 @@
>  
>  void
>  ion::Invalidate(JSContext *cx, const Vector<JSScript *> &invalid)
>  {
> +    // Add an invalidation reference to all invalidated IonScripts.

Nit: can we add something like "to indicate to to the traversal which frames have been invalidated"?
Attachment #586575 - Flags: review?(christopher.leary) → review+
http://hg.mozilla.org/projects/ionmonkey/rev/ef75b074399c
http://hg.mozilla.org/projects/ionmonkey/rev/15f251140365
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.