Closed Bug 716091 Opened 13 years ago Closed 4 years ago

mac platform layer's cache of the role can get out of date

Categories

(Core :: Disability Access APIs, defect, P3)

x86_64
macOS
defect

Tracking

()

RESOLVED INVALID

People

(Reporter: tbsaunde, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [mac2020_1])

I'd prefer that the platform layer just called Role(0 when it needs it, it shouldn't be particularly slow, but if it turns out that is too slow, you should update mRole atleast when the accessibles mRoleMapEntry is updated, and maybe other times I'm not sure yet.
accessible is recreated whenever its role is changed (at least that's how it should be and true for ARIA role attribute is changed). So the only one problem of cached role on platform side I can see is wasting extra memory per accessible. Calling Role() method shouldn't be slow because in most cases it's just a call of virtual method.
Blocks: cleana11y
Assignee: nobody → hub
Assignee: hub → nobody
Whiteboard: [mac2020_1]
Priority: -- → P3

We probably shouldn't cache the role, it doesn't give any real benefit. That said, we also recreate accessibles on role changes, so I am going to close this.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.