Last Comment Bug 716136 - Add JSGC_GENERATIONAL flag to build system
: Add JSGC_GENERATIONAL flag to build system
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla13
Assigned To: Terrence Cole [:terrence]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-06 16:55 PST by Terrence Cole [:terrence]
Modified: 2012-02-02 06:54 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1: trivial (1.48 KB, patch)
2012-01-06 17:08 PST, Terrence Cole [:terrence]
no flags Details | Diff | Splinter Review
v2: opt-in (1.48 KB, patch)
2012-02-01 18:45 PST, Terrence Cole [:terrence]
wmccloskey: review+
Details | Diff | Splinter Review

Description Terrence Cole [:terrence] 2012-01-06 16:55:57 PST
These are already in the tree in several places to protect (empty) post write barriers.  We should get these methods tested on more compilers by exposing them while they are still empty.
Comment 1 Terrence Cole [:terrence] 2012-01-06 17:08:09 PST
Created attachment 586617 [details] [diff] [review]
v1: trivial

This is copied directly from JSGC_INCREMENTAL.  Is it too early to expose the empty post barriers, or should I have done this last year, before I started?
Comment 2 Bill McCloskey (:billm) 2012-02-01 17:01:32 PST
Could you make this opt-in instead of opt-out? That is, copy the root analysis one rather than the incremental one?
Comment 3 Terrence Cole [:terrence] 2012-02-01 18:45:50 PST
Created attachment 593700 [details] [diff] [review]
v2: opt-in
Comment 4 Ed Morley [:emorley] 2012-02-02 06:54:50 PST
https://hg.mozilla.org/mozilla-central/rev/44d3d54b6fc8

Note You need to log in before you can comment on or make changes to this bug.