716215 - nsHTMLEditor::IsEmptyNodeImpl checks if the parent is a form widget instead of the child

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

<http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/nsHTMLEditor.cpp#4958> has

4921   while (child)
4923     nsCOMPtr<nsIDOMNode> node = child;
4959           else if (nsHTMLEditUtils::IsFormWidget(aNode))
4960           { // break out if we find we aren't empty
4961             *outIsEmptyNode = false;
4962             return NS_OK;
4963           }

where it probably wants to check nsHTMLEditUtils::IsFormWidget(node). Ehsan, could you confirm?

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

In fact, there's an early return for nsHTMLEditUtils::IsFormWidget(aNode) at line 4904.

Comment 2

[(no longer active)]

(In reply to Ms2ger from comment #0)
> <http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/
> nsHTMLEditor.cpp#4958> has
> 
> 4921   while (child)
> 4923     nsCOMPtr<nsIDOMNode> node = child;
> 4959           else if (nsHTMLEditUtils::IsFormWidget(aNode))
> 4960           { // break out if we find we aren't empty
> 4961             *outIsEmptyNode = false;
> 4962             return NS_OK;
> 4963           }
> 
> where it probably wants to check nsHTMLEditUtils::IsFormWidget(node). Ehsan,
> could you confirm?

Yes, you're right.

Comment 3

[Jignesh Kakadiya [:jhk]]

Attachment: Patch

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 587274 [details] [diff] [review]
Patch

Thanks, looks good.

Comment 5

[(no longer active)]

Comment on attachment 587274 [details] [diff] [review]
Patch

Looks great, Jignesh, thanks a lot!  Do you have try server access?  Have you tested this patch on the try server?

Comment 6

[Jignesh Kakadiya [:jhk]]

> Do you have try server access?  Have
> you tested this patch on the try server?

No. I have applied for try access and will get it soon :).

Thanks!

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://tbpl.mozilla.org/?tree=Try&rev=2289a605627e

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Thanks for the patch!

https://hg.mozilla.org/mozilla-central/rev/c42d08fdec34