716293 - IO on the main thread caused by nsDiskCacheOutputStream::Close()

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Michal Novotny [:michal]]

nsDiskCacheOutputStream::Close() is called on the main thread if all nsInputStreamTeeWriteEvent events finish before nsStreamListenerTee::OnStartRequest() is called.

Comment 1

[Michal Novotny [:michal]]

Attachment: fix - release sink on the same thread where the data is written

Comment 2

[Bjarne (:bjarne)]

Comment on attachment 586742 [details] [diff] [review]
fix - release sink on the same thread where the data is written

Review of attachment 586742 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable - does it pass tryserver? Is there a way we can have a test for this?

Please re-request review after addressing the above questions.

::: netwerk/base/src/nsStreamListenerTee.cpp
@@ +67,5 @@
>      if (mInputTee) {
>          mInputTee->SetSink(nsnull);
>          mInputTee = 0;
>      }
> +

Nit: Please add a comment including the bug-number.

Comment 3

[Michal Novotny [:michal]]

Attachment: patch v2 - added a comment

(In reply to Bjarne (:bjarne) from comment #2)
> Looks reasonable - does it pass tryserver?

No, it doesn't. But tryserver is useless these days.

result with patch: https://tbpl.mozilla.org/?tree=Try&rev=96d185e8731e
result without it: https://tbpl.mozilla.org/?tree=Try&rev=bd7e5b7b5ea3


> Is there a way we can have a test for this?

I don't see a way how to test it.

Comment 4

[Bjarne (:bjarne)]

Comment on attachment 587008 [details] [diff] [review]
patch v2 - added a comment

Review of attachment 587008 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks ok. Would be more happy if it passed try and/or had a test, but fair enough...

Comment 5

[Michal Novotny [:michal]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/dc23947abad9

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/dc23947abad9