71637 - CSS errors in chrome

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

DESCRIPTION:  Using CSS error reporting (which can be enabled by uncommenting
the #define at the top of nsCSSScanner.h), I found a bunch of CSS errors in the
chrome CSS files.  I'm going to attach a patch that corrects many of them.

However, this probably shouldn't be checked in as is because:
 * it's not always clear what the intent of the CSS author was
 * some changes to invalid identifiers used as class names should be reflected
   in the markup.  (These could also be fixed by escaping the characters that
   can't be part of identifiers when unescaped, but I don't recommend that.)
 * People who know what the rules do should probably check that the old effect
   (where declarations or rules were ignored due to the errors) wasn't what
    was intended.

So if anybody's interested in picking this up, go right ahead...

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch fixing some CSS errors

Comment 2

[Joe Hewitt (gone)]

Most of the modern css errors were fixed in the 65745 checkin.

Comment 3

[Manoj]

check out www.msnbc.com The adherence to the stylesheet is flaky.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch fixing some more CSS errors

Comment 5

[Joe Hewitt (gone)]

Mass reassigning my theme bugs to Shuehan.

Comment 6

[shliang]

Attachment: update of previous patches

Comment 7

[Joe Hewitt (gone)]

Comment on attachment 54004 [details] [diff] [review]
update of previous patches

sr=hewitt

Comment 8

[andreww]

Comment on attachment 54004 [details] [diff] [review]
update of previous patches

r=andreww

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

What about:

/editor/ui/composer/content/TextEditorAppShell.xul, line 133 -- <spacer
class="separator_small"/>
/themes/classic/editor/mac/textEditor.css, line 25 -- .separator_small {
/themes/classic/editor/win/textEditor.css, line 25 -- .separator_small {

?

Comment 10

[shliang]

Attachment: one more

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 59562 [details] [diff] [review]
one more

r=dbaron

Comment 12

[Joe Hewitt (gone)]

Comment on attachment 59562 [details] [diff] [review]
one more

sr=hewitt

Comment 13

[shliang]

second patch checked in

Comment 14

[Patty Mac]

Verified the patch