CSS errors in chrome

VERIFIED FIXED in mozilla0.9.7

Status

VERIFIED FIXED
18 years ago
10 years ago

People

(Reporter: dbaron, Assigned: shliang)

Tracking

Trunk
mozilla0.9.7

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

DESCRIPTION:  Using CSS error reporting (which can be enabled by uncommenting
the #define at the top of nsCSSScanner.h), I found a bunch of CSS errors in the
chrome CSS files.  I'm going to attach a patch that corrects many of them.

However, this probably shouldn't be checked in as is because:
 * it's not always clear what the intent of the CSS author was
 * some changes to invalid identifiers used as class names should be reflected
   in the markup.  (These could also be fixed by escaping the characters that
   can't be part of identifiers when unescaped, but I don't recommend that.)
 * People who know what the rules do should probably check that the old effect
   (where declarations or rules were ignored due to the errors) wasn't what
    was intended.

So if anybody's interested in picking this up, go right ahead...
Created attachment 27415 [details] [diff] [review]
patch fixing some CSS errors

Comment 2

18 years ago
Most of the modern css errors were fixed in the 65745 checkin.
Status: NEW → ASSIGNED

Comment 3

18 years ago
check out www.msnbc.com The adherence to the stylesheet is flaky.
Created attachment 45612 [details] [diff] [review]
patch fixing some more CSS errors

Comment 5

17 years ago
Mass reassigning my theme bugs to Shuehan.
Assignee: hewitt → shliang
Status: ASSIGNED → NEW
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
(Assignee)

Comment 6

17 years ago
Created attachment 54004 [details] [diff] [review]
update of previous patches
(Assignee)

Updated

17 years ago
Blocks: 105174
(Assignee)

Updated

17 years ago
Target Milestone: mozilla1.0 → mozilla0.9.7

Comment 7

17 years ago
Comment on attachment 54004 [details] [diff] [review]
update of previous patches

sr=hewitt
Attachment #54004 - Flags: superreview+

Comment 8

17 years ago
Comment on attachment 54004 [details] [diff] [review]
update of previous patches

r=andreww
Attachment #54004 - Flags: review+
What about:

/editor/ui/composer/content/TextEditorAppShell.xul, line 133 -- <spacer
class="separator_small"/>
/themes/classic/editor/mac/textEditor.css, line 25 -- .separator_small {
/themes/classic/editor/win/textEditor.css, line 25 -- .separator_small {

?
(Assignee)

Comment 10

17 years ago
Created attachment 59562 [details] [diff] [review]
one more
Comment on attachment 59562 [details] [diff] [review]
one more

r=dbaron
Attachment #59562 - Flags: review+

Comment 12

17 years ago
Comment on attachment 59562 [details] [diff] [review]
one more

sr=hewitt
Attachment #59562 - Flags: superreview+
(Assignee)

Comment 13

17 years ago
second patch checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 14

17 years ago
Verified the patch
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.