Closed Bug 716380 Opened 8 years ago Closed 8 years ago

socket transport n != 0 assertion

Categories

(Core :: Networking: HTTP, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: mcmanus, Assigned: mcmanus)

References

Details

Attachments

(1 file)

-    NS_ASSERTION(n != 0, "unexpected return value");

is firing when doing ssl handshakes with spdy enabled. (nsSocketTransport2.cpp around 585)

it is checking the PR_Write() return value - 0 is actually fine and expected in this case (where 0 was submitted), I've read through the sockettransport code as well as the nsIOutputStream interface and it shouldn't be a problem.

the error seems to be with the NSPR documentation of PR_Write(). Brian is going to follow up on that one.
Attached patch patch 0Splinter Review
Attachment #586813 - Flags: review?(honzab.moz)
Blocks: 719609
Comment on attachment 586813 [details] [diff] [review]
patch 0

Review of attachment 586813 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab

Maybe, do this check/assertion only if count != 0 ?
Attachment #586813 - Flags: review?(honzab.moz) → review+
https://hg.mozilla.org/mozilla-central/rev/a9823c18b423
Assignee: nobody → mcmanus
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.