716380 - socket transport n != 0 assertion

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Patrick McManus [:mcmanus]]

-    NS_ASSERTION(n != 0, "unexpected return value");

is firing when doing ssl handshakes with spdy enabled. (nsSocketTransport2.cpp around 585)

it is checking the PR_Write() return value - 0 is actually fine and expected in this case (where 0 was submitted), I've read through the sockettransport code as well as the nsIOutputStream interface and it shouldn't be a problem.

the error seems to be with the NSPR documentation of PR_Write(). Brian is going to follow up on that one.

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: patch 0

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 586813 [details] [diff] [review]
patch 0

Review of attachment 586813 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab

Maybe, do this check/assertion only if count != 0 ?

Comment 3

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9823c18b423

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a9823c18b423