socket transport n != 0 assertion

RESOLVED FIXED in mozilla12

Status

()

Core
Networking: HTTP
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mcmanus, Assigned: mcmanus)

Tracking

unspecified
mozilla12
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
-    NS_ASSERTION(n != 0, "unexpected return value");

is firing when doing ssl handshakes with spdy enabled. (nsSocketTransport2.cpp around 585)

it is checking the PR_Write() return value - 0 is actually fine and expected in this case (where 0 was submitted), I've read through the sockettransport code as well as the nsIOutputStream interface and it shouldn't be a problem.

the error seems to be with the NSPR documentation of PR_Write(). Brian is going to follow up on that one.
(Assignee)

Comment 1

6 years ago
Created attachment 586813 [details] [diff] [review]
patch 0
Attachment #586813 - Flags: review?(honzab.moz)
(Assignee)

Updated

6 years ago
Blocks: 719609
Comment on attachment 586813 [details] [diff] [review]
patch 0

Review of attachment 586813 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab

Maybe, do this check/assertion only if count != 0 ?
Attachment #586813 - Flags: review?(honzab.moz) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9823c18b423

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/a9823c18b423
Assignee: nobody → mcmanus
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.