716410 - Use calendar specific logging methods in CalDAV provider

Status: NEW

(Calendar :: General, enhancement)

Comment 1

[Stefan Fleiter (:sfleiter)]

Attachment: Use calendar specific logging methods in CalDAV provider

Comment 2

[Stefan Fleiter (:sfleiter)]

diffstat calendar_logging_caldav.patch
 calDavCalendar.js |  209 ++++++++++++++++++++++--------------------------------
 1 file changed, 88 insertions(+), 121 deletions(-)

Comment 3

[Stefan Fleiter (:sfleiter)]

Attachment: Use calendar specific logging methods in CalDAV provider, including calDavRequestHandlers.js

The former patch missed 1 cal.ERROR in calDavCalendar.js and the whole calDavRequestHandlers.js file.

New diffstat:
 calDavCalendar.js        |  209 +++++++++++++++++++----------------------------
 calDavRequestHandlers.js |   52 +++++------
 2 files changed, 114 insertions(+), 147 deletions(-)

33 lines less of code, all messages correlatable to a specific calendar and grep-able log output seems like an improvement to me.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 586845 [details] [diff] [review]
Use calendar specific logging methods in CalDAV provider, including calDavRequestHandlers.js

Does this patch take care of all provider log messages, as ssitter noted in bug 716400? Also, consider LOGverbose as noted in mentioned bug.

The things you changed look good, r=philipp

Comment 5

[Martin Schröder [:mschroeder]]

Stefan, any progress update? Is this patch ready for checkin?