Closed
Bug 716415
Opened 13 years ago
Closed 12 years ago
[Skia] Update skia to svn revision 2980
Categories
(Core :: Graphics, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
(Blocks 1 open bug)
Details
Attachments
(7 files, 2 obsolete files)
|
413 bytes,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
|
1.45 MB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
|
52.76 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
|
1.11 KB,
patch
|
gw280
:
review+
|
Details | Diff | Splinter Review |
|
2.60 KB,
patch
|
gw280
:
review+
|
Details | Diff | Splinter Review |
|
3.69 KB,
patch
|
gw280
:
review+
|
Details | Diff | Splinter Review |
|
491 bytes,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
Updating to the latest trunk skia to get soft clipping, among other fixes.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #586848 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #586849 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #586850 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Comment 4•13 years ago
|
||
Attachment #586851 -
Flags: review?(gwright)
|
|
Assignee | |
Comment 5•13 years ago
|
||
Attachment #586852 -
Flags: review?(gwright)
|
|
Assignee | |
Comment 6•13 years ago
|
||
Attachment #586853 -
Flags: review?(gwright)
|
||
Comment 7•13 years ago
|
||
Comment on attachment 586853 [details] [diff] [review] Enable soft clipping with Skia in Azure Can we get away with not using soft clipping on mobile for perf and pixel size reasons?
|
|
||
Updated•13 years ago
|
Attachment #586848 -
Flags: review?(jmuizelaar) → review+
|
|
||
Comment 8•13 years ago
|
||
Comment on attachment 586850 [details] [diff] [review] Apply mozilla patches and fix patch files This doesn't really need a review
Attachment #586850 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 9•13 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #7) > Comment on attachment 586853 [details] [diff] [review] > Enable soft clipping with Skia in Azure > > Can we get away with not using soft clipping on mobile for perf and pixel > size reasons? Seems reasonable to me. I'll fix this
|
|
Assignee | |
Comment 10•13 years ago
|
||
Attachment #586853 -
Attachment is obsolete: true
Attachment #586853 -
Flags: review?(gwright)
Attachment #587246 -
Flags: review?(gwright)
|
||
Comment 11•13 years ago
|
||
Comment on attachment 586851 [details] [diff] [review] Update Azure for Skia API changes lgtm
Attachment #586851 -
Flags: review?(gwright) → review+
|
|
||
Comment 12•13 years ago
|
||
Comment on attachment 586852 [details] [diff] [review] Store our changes to SkUserConfig.h in a patch file I'd prefer a comment above each #define stating why we think it's necessary and/or what it does
|
|
||
Comment 13•13 years ago
|
||
Comment on attachment 587246 [details] [diff] [review] Enable soft clipping with Skia in Azure v2 would we only ever want the choice of soft vs hard clipping done at compile time? would this make more sense as a run-time option?
|
|
Assignee | |
Comment 14•12 years ago
|
||
Attachment #586852 -
Attachment is obsolete: true
Attachment #586852 -
Flags: review?(gwright)
Attachment #588766 -
Flags: review?(gwright)
|
|
Assignee | |
Comment 15•12 years ago
|
||
(In reply to George Wright (:gw280) from comment #13) > would we only ever want the choice of soft vs hard clipping done at compile > time? would this make more sense as a run-time option? I don't think we need this for the time being. Easy enough to add a preference later if it becomes a priority.
|
|
Assignee | |
Comment 16•12 years ago
|
||
Attachment #589342 -
Flags: review?(jmuizelaar)
|
|
||
Comment 17•12 years ago
|
||
Comment on attachment 587246 [details] [diff] [review] Enable soft clipping with Skia in Azure v2 lgtm if we don't want this as a pref for now
Attachment #587246 -
Flags: review?(gwright) → review+
|
|
||
Updated•12 years ago
|
Attachment #588766 -
Flags: review?(gwright) → review+
|
|
Assignee | |
Comment 18•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/be4ed2c8f446 https://hg.mozilla.org/integration/mozilla-inbound/rev/7e9a396c0a56 https://hg.mozilla.org/integration/mozilla-inbound/rev/be5d69db8531 https://hg.mozilla.org/integration/mozilla-inbound/rev/e5131d25c42c https://hg.mozilla.org/integration/mozilla-inbound/rev/47db1c632a61 https://hg.mozilla.org/integration/mozilla-inbound/rev/19c3a59d61ad https://hg.mozilla.org/integration/mozilla-inbound/rev/fced79b75704
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → matt.woodrow
|
|
Assignee | |
Comment 19•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8de271eee34b
|
|
||
Updated•12 years ago
|
Attachment #589342 -
Flags: review?(jmuizelaar) → review+
|
|
||
Updated•12 years ago
|
Attachment #586849 -
Flags: review?(jmuizelaar) → review+
|
||
Comment 20•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/be4ed2c8f446 https://hg.mozilla.org/mozilla-central/rev/7e9a396c0a56 https://hg.mozilla.org/mozilla-central/rev/be5d69db8531 https://hg.mozilla.org/mozilla-central/rev/e5131d25c42c https://hg.mozilla.org/mozilla-central/rev/47db1c632a61 https://hg.mozilla.org/mozilla-central/rev/19c3a59d61ad https://hg.mozilla.org/mozilla-central/rev/fced79b75704 https://hg.mozilla.org/mozilla-central/rev/8de271eee34b
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
|
||
Updated•9 years ago
|
Blocks: skia-updates
|
||
Updated•5 years ago
|
Type: defect → enhancement
You need to log in
before you can comment on or make changes to this bug.
Description
•