Note: There are a few cases of duplicates in user autocompletion which are being worked on.

[Skia] Update skia to svn revision 2980

RESOLVED FIXED in mozilla12

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

Tracking

(Blocks: 1 bug)

unspecified
mozilla12
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(7 attachments, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Updating to the latest trunk skia to get soft clipping, among other fixes.
(Assignee)

Comment 1

6 years ago
Created attachment 586848 [details] [diff] [review]
Add missing MOZILLA_README file
Attachment #586848 - Flags: review?(jmuizelaar)
(Assignee)

Comment 2

6 years ago
Created attachment 586849 [details] [diff] [review]
Update skia code to revision 2980
Attachment #586849 - Flags: review?(jmuizelaar)
(Assignee)

Comment 3

6 years ago
Created attachment 586850 [details] [diff] [review]
Apply mozilla patches and fix patch files
Attachment #586850 - Flags: review?(jmuizelaar)
(Assignee)

Comment 4

6 years ago
Created attachment 586851 [details] [diff] [review]
Update Azure for Skia API changes
Attachment #586851 - Flags: review?(gwright)
(Assignee)

Comment 5

6 years ago
Created attachment 586852 [details] [diff] [review]
Store our changes to SkUserConfig.h in a patch file
Attachment #586852 - Flags: review?(gwright)
(Assignee)

Comment 6

6 years ago
Created attachment 586853 [details] [diff] [review]
Enable soft clipping with Skia in Azure
Attachment #586853 - Flags: review?(gwright)
Comment on attachment 586853 [details] [diff] [review]
Enable soft clipping with Skia in Azure

Can we get away with not using soft clipping on mobile for perf and pixel size reasons?
Attachment #586848 - Flags: review?(jmuizelaar) → review+
Comment on attachment 586850 [details] [diff] [review]
Apply mozilla patches and fix patch files

This doesn't really need a review
Attachment #586850 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 9

6 years ago
(In reply to Jeff Muizelaar [:jrmuizel] from comment #7)
> Comment on attachment 586853 [details] [diff] [review]
> Enable soft clipping with Skia in Azure
> 
> Can we get away with not using soft clipping on mobile for perf and pixel
> size reasons?

Seems reasonable to me. I'll fix this
(Assignee)

Comment 10

6 years ago
Created attachment 587246 [details] [diff] [review]
Enable soft clipping with Skia in Azure v2
Attachment #586853 - Attachment is obsolete: true
Attachment #586853 - Flags: review?(gwright)
Attachment #587246 - Flags: review?(gwright)
Comment on attachment 586851 [details] [diff] [review]
Update Azure for Skia API changes

lgtm
Attachment #586851 - Flags: review?(gwright) → review+
Comment on attachment 586852 [details] [diff] [review]
Store our changes to SkUserConfig.h in a patch file

I'd prefer a comment above each #define stating why we think it's necessary and/or what it does
Comment on attachment 587246 [details] [diff] [review]
Enable soft clipping with Skia in Azure v2

would we only ever want the choice of soft vs hard clipping done at compile time? would this make more sense as a run-time option?
(Assignee)

Comment 14

6 years ago
Created attachment 588766 [details] [diff] [review]
Store our changes to SkUserConfig.h in a patch file v2
Attachment #586852 - Attachment is obsolete: true
Attachment #586852 - Flags: review?(gwright)
Attachment #588766 - Flags: review?(gwright)
(Assignee)

Comment 15

6 years ago
(In reply to George Wright (:gw280) from comment #13) 
> would we only ever want the choice of soft vs hard clipping done at compile
> time? would this make more sense as a run-time option?

I don't think we need this for the time being. Easy enough to add a preference later if it becomes a priority.
(Assignee)

Comment 16

6 years ago
Created attachment 589342 [details] [diff] [review]
Fix windows build
Attachment #589342 - Flags: review?(jmuizelaar)
Comment on attachment 587246 [details] [diff] [review]
Enable soft clipping with Skia in Azure v2

lgtm if we don't want this as a pref for now
Attachment #587246 - Flags: review?(gwright) → review+
Attachment #588766 - Flags: review?(gwright) → review+
(Assignee)

Comment 18

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/be4ed2c8f446
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e9a396c0a56
https://hg.mozilla.org/integration/mozilla-inbound/rev/be5d69db8531
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5131d25c42c
https://hg.mozilla.org/integration/mozilla-inbound/rev/47db1c632a61
https://hg.mozilla.org/integration/mozilla-inbound/rev/19c3a59d61ad
https://hg.mozilla.org/integration/mozilla-inbound/rev/fced79b75704
(Assignee)

Updated

6 years ago
Assignee: nobody → matt.woodrow
(Assignee)

Comment 19

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8de271eee34b
Attachment #589342 - Flags: review?(jmuizelaar) → review+
Attachment #586849 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/be4ed2c8f446
https://hg.mozilla.org/mozilla-central/rev/7e9a396c0a56
https://hg.mozilla.org/mozilla-central/rev/be5d69db8531
https://hg.mozilla.org/mozilla-central/rev/e5131d25c42c
https://hg.mozilla.org/mozilla-central/rev/47db1c632a61
https://hg.mozilla.org/mozilla-central/rev/19c3a59d61ad
https://hg.mozilla.org/mozilla-central/rev/fced79b75704
https://hg.mozilla.org/mozilla-central/rev/8de271eee34b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Blocks: 1210886
You need to log in before you can comment on or make changes to this bug.