Last Comment Bug 716415 - [Skia] Update skia to svn revision 2980
: [Skia] Update skia to svn revision 2980
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla12
Assigned To: Matt Woodrow (:mattwoodrow)
:
:
Mentors:
Depends on:
Blocks: skia-updates 687187
  Show dependency treegraph
 
Reported: 2012-01-08 14:57 PST by Matt Woodrow (:mattwoodrow)
Modified: 2016-04-07 11:49 PDT (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add missing MOZILLA_README file (413 bytes, patch)
2012-01-08 15:03 PST, Matt Woodrow (:mattwoodrow)
jmuizelaar: review+
Details | Diff | Splinter Review
Update skia code to revision 2980 (1.45 MB, patch)
2012-01-08 15:03 PST, Matt Woodrow (:mattwoodrow)
jmuizelaar: review+
Details | Diff | Splinter Review
Apply mozilla patches and fix patch files (52.76 KB, patch)
2012-01-08 15:04 PST, Matt Woodrow (:mattwoodrow)
jmuizelaar: review+
Details | Diff | Splinter Review
Update Azure for Skia API changes (1.11 KB, patch)
2012-01-08 15:05 PST, Matt Woodrow (:mattwoodrow)
gwright: review+
Details | Diff | Splinter Review
Store our changes to SkUserConfig.h in a patch file (3.30 KB, patch)
2012-01-08 15:06 PST, Matt Woodrow (:mattwoodrow)
no flags Details | Diff | Splinter Review
Enable soft clipping with Skia in Azure (1.82 KB, patch)
2012-01-08 15:06 PST, Matt Woodrow (:mattwoodrow)
no flags Details | Diff | Splinter Review
Enable soft clipping with Skia in Azure v2 (2.60 KB, patch)
2012-01-09 21:57 PST, Matt Woodrow (:mattwoodrow)
gwright: review+
Details | Diff | Splinter Review
Store our changes to SkUserConfig.h in a patch file v2 (3.69 KB, patch)
2012-01-15 13:07 PST, Matt Woodrow (:mattwoodrow)
gwright: review+
Details | Diff | Splinter Review
Fix windows build (491 bytes, patch)
2012-01-17 16:26 PST, Matt Woodrow (:mattwoodrow)
jmuizelaar: review+
Details | Diff | Splinter Review

Description Matt Woodrow (:mattwoodrow) 2012-01-08 14:57:16 PST
Updating to the latest trunk skia to get soft clipping, among other fixes.
Comment 1 Matt Woodrow (:mattwoodrow) 2012-01-08 15:03:08 PST
Created attachment 586848 [details] [diff] [review]
Add missing MOZILLA_README file
Comment 2 Matt Woodrow (:mattwoodrow) 2012-01-08 15:03:51 PST
Created attachment 586849 [details] [diff] [review]
Update skia code to revision 2980
Comment 3 Matt Woodrow (:mattwoodrow) 2012-01-08 15:04:28 PST
Created attachment 586850 [details] [diff] [review]
Apply mozilla patches and fix patch files
Comment 4 Matt Woodrow (:mattwoodrow) 2012-01-08 15:05:30 PST
Created attachment 586851 [details] [diff] [review]
Update Azure for Skia API changes
Comment 5 Matt Woodrow (:mattwoodrow) 2012-01-08 15:06:15 PST
Created attachment 586852 [details] [diff] [review]
Store our changes to SkUserConfig.h in a patch file
Comment 6 Matt Woodrow (:mattwoodrow) 2012-01-08 15:06:46 PST
Created attachment 586853 [details] [diff] [review]
Enable soft clipping with Skia in Azure
Comment 7 Jeff Muizelaar [:jrmuizel] 2012-01-08 17:02:42 PST
Comment on attachment 586853 [details] [diff] [review]
Enable soft clipping with Skia in Azure

Can we get away with not using soft clipping on mobile for perf and pixel size reasons?
Comment 8 Jeff Muizelaar [:jrmuizel] 2012-01-08 17:05:04 PST
Comment on attachment 586850 [details] [diff] [review]
Apply mozilla patches and fix patch files

This doesn't really need a review
Comment 9 Matt Woodrow (:mattwoodrow) 2012-01-09 21:44:38 PST
(In reply to Jeff Muizelaar [:jrmuizel] from comment #7)
> Comment on attachment 586853 [details] [diff] [review]
> Enable soft clipping with Skia in Azure
> 
> Can we get away with not using soft clipping on mobile for perf and pixel
> size reasons?

Seems reasonable to me. I'll fix this
Comment 10 Matt Woodrow (:mattwoodrow) 2012-01-09 21:57:33 PST
Created attachment 587246 [details] [diff] [review]
Enable soft clipping with Skia in Azure v2
Comment 11 George Wright (:gw280) (:gwright) 2012-01-12 11:11:13 PST
Comment on attachment 586851 [details] [diff] [review]
Update Azure for Skia API changes

lgtm
Comment 12 George Wright (:gw280) (:gwright) 2012-01-12 11:15:34 PST
Comment on attachment 586852 [details] [diff] [review]
Store our changes to SkUserConfig.h in a patch file

I'd prefer a comment above each #define stating why we think it's necessary and/or what it does
Comment 13 George Wright (:gw280) (:gwright) 2012-01-12 11:18:33 PST
Comment on attachment 587246 [details] [diff] [review]
Enable soft clipping with Skia in Azure v2

would we only ever want the choice of soft vs hard clipping done at compile time? would this make more sense as a run-time option?
Comment 14 Matt Woodrow (:mattwoodrow) 2012-01-15 13:07:59 PST
Created attachment 588766 [details] [diff] [review]
Store our changes to SkUserConfig.h in a patch file v2
Comment 15 Matt Woodrow (:mattwoodrow) 2012-01-15 13:08:40 PST
(In reply to George Wright (:gw280) from comment #13) 
> would we only ever want the choice of soft vs hard clipping done at compile
> time? would this make more sense as a run-time option?

I don't think we need this for the time being. Easy enough to add a preference later if it becomes a priority.
Comment 16 Matt Woodrow (:mattwoodrow) 2012-01-17 16:26:43 PST
Created attachment 589342 [details] [diff] [review]
Fix windows build
Comment 17 George Wright (:gw280) (:gwright) 2012-01-18 00:00:13 PST
Comment on attachment 587246 [details] [diff] [review]
Enable soft clipping with Skia in Azure v2

lgtm if we don't want this as a pref for now
Comment 19 Matt Woodrow (:mattwoodrow) 2012-01-18 20:56:53 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/8de271eee34b

Note You need to log in before you can comment on or make changes to this bug.