Closed Bug 716415 Opened 13 years ago Closed 13 years ago

[Skia] Update skia to svn revision 2980

Categories

(Core :: Graphics, enhancement)

Product:
Core
Component:
Graphics
Platform:
x86
macOS
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla12

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

(Blocks 1 open bug)

Details

Attachments

(7 files, 2 obsolete files)

Add missing MOZILLA_README file
413 bytes, patch
jrmuizel
: review+
Details | Diff | Splinter Review
Update skia code to revision 2980
1.45 MB, patch
jrmuizel
: review+
Details | Diff | Splinter Review
Apply mozilla patches and fix patch files
52.76 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review
Update Azure for Skia API changes
1.11 KB, patch
gw280
: review+
Details | Diff | Splinter Review
Enable soft clipping with Skia in Azure v2
2.60 KB, patch
gw280
: review+
Details | Diff | Splinter Review
Store our changes to SkUserConfig.h in a patch file v2
3.69 KB, patch
gw280
: review+
Details | Diff | Splinter Review
Fix windows build
491 bytes, patch
jrmuizel
: review+
Details | Diff | Splinter Review
Updating to the latest trunk skia to get soft clipping, among other fixes.
Attachment #586848 - Flags: review?(jmuizelaar)
Attachment #586849 - Flags: review?(jmuizelaar)
Attachment #586850 - Flags: review?(jmuizelaar)
Attachment #586851 - Flags: review?(gwright)
Attachment #586852 - Flags: review?(gwright)
Attachment #586853 - Flags: review?(gwright)
Comment on attachment 586853 [details] [diff] [review] Enable soft clipping with Skia in Azure Can we get away with not using soft clipping on mobile for perf and pixel size reasons?
Attachment #586848 - Flags: review?(jmuizelaar) → review+
Comment on attachment 586850 [details] [diff] [review] Apply mozilla patches and fix patch files This doesn't really need a review
Attachment #586850 - Flags: review?(jmuizelaar) → review+
(In reply to Jeff Muizelaar [:jrmuizel] from comment #7) > Comment on attachment 586853 [details] [diff] [review] > Enable soft clipping with Skia in Azure > > Can we get away with not using soft clipping on mobile for perf and pixel > size reasons? Seems reasonable to me. I'll fix this
Attachment #586853 - Attachment is obsolete: true
Attachment #586853 - Flags: review?(gwright)
Attachment #587246 - Flags: review?(gwright)
Comment on attachment 586851 [details] [diff] [review] Update Azure for Skia API changes lgtm
Attachment #586851 - Flags: review?(gwright) → review+
Comment on attachment 586852 [details] [diff] [review] Store our changes to SkUserConfig.h in a patch file I'd prefer a comment above each #define stating why we think it's necessary and/or what it does
Comment on attachment 587246 [details] [diff] [review] Enable soft clipping with Skia in Azure v2 would we only ever want the choice of soft vs hard clipping done at compile time? would this make more sense as a run-time option?
Attachment #586852 - Attachment is obsolete: true
Attachment #586852 - Flags: review?(gwright)
Attachment #588766 - Flags: review?(gwright)
(In reply to George Wright (:gw280) from comment #13) > would we only ever want the choice of soft vs hard clipping done at compile > time? would this make more sense as a run-time option? I don't think we need this for the time being. Easy enough to add a preference later if it becomes a priority.
Attachment #589342 - Flags: review?(jmuizelaar)
Comment on attachment 587246 [details] [diff] [review] Enable soft clipping with Skia in Azure v2 lgtm if we don't want this as a pref for now
Attachment #587246 - Flags: review?(gwright) → review+
Attachment #588766 - Flags: review?(gwright) → review+
Assignee: nobody → matt.woodrow
Attachment #589342 - Flags: review?(jmuizelaar) → review+
Attachment #586849 - Flags: review?(jmuizelaar) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: