716515 - Password not filled if username selected from autocomplete suggestions

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Camelia Urian]

Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:12.0a1) Gecko/20120108 Firefox/12.0a1 Fennec/12.0a1
Device: Samsung Nexus S
OS: Android 2.3

Steps to reproduce:
1. Login to www.litmus.mozilla.org with several accounts (user & pass) and save passwords for all. 
2. Open a new tab and go to litmus.mozilla.org, select login
3. Start typing username previously saved.
4. Select username from Form Autocomplete Suggestions pop-up.
5. Move focus to the password field.

Expected results:
 The password field should be filled automatically

Actual results:
 The password field is not filled.

Note: 
 - if user name is typed(not selected from suggestions list), then password is field is filled automatically when focus is moved on password field.

Comment 1

[Aaron Train [:aaronmt]]

Shouldn't you already be signed in by opening another tab and visiting the same site?

Anyhow, signing out, and going to Litmus, tapping sign-in, I see the fields pre-populated with my credentials saved. This works for me.

Can you re-test?

--
Samsung Nexus S (Android 4.0.3)
Mozilla/5.0 (Android; armv7l; rv:12.0a1) Gecko/20120109 Firefox/12.0a1 Fennec/12.0a1

Comment 2

[Camelia Urian]

Aaron, if you sign in and save password for 2 different accounts and sign out, when you go to the login page the fields are not pre-populated.

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

The loginManager is listening for a DOMAutocomplete event on the input element:

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/passwordmgr/nsLoginManager.js#347

We fired that in XUL here:

http://mxr.mozilla.org/mozilla-central/source/mobile/xul/chrome/content/forms.js#307

Note, if you're like me and try testing this on touch.facebook.com, it won't work because their password field is not an input type="password" until you focus it and start typing.

Comment 4

[:Margaret Leibovic]

Comment on attachment 605881 [details] [diff] [review]
Patch

Good catch!

Comment 5

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/65605fe6063d

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/65605fe6063d

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6273daa1141e

Comment 8

[Paul Feher]

Verified/fixed on:

Aurora Fennec 13.0a2 (2012-03-25)
Nightly Fennec 14.0a1 (2012-03-25)
Device: Samsung Nexus S
OS: Android 2.3.6