Closed Bug 716541 Opened 8 years ago Closed 8 years ago

Do not fail build on -Wuninitialized when treating warnings as errors

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla12

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
No description provided.
Attachment #586990 - Flags: review?(mh+mozilla)
This was requested during the discussion in dev-platform.
Whiteboard: [needs review]
Blocks: 703121
Attachment #586990 - Flags: review?(mh+mozilla) → review+
I think this needs s/initialized/uninitialized/

At least, right now when I build with this and FAIL_ON_WARNINGS=1 added in content/smil, I get the following build error when I hit content/smil:
> error: -Werror=initialized: no option -Winitialized

Also, "man g++" confirms that there's no "-Winitialized", but there is "-Wuninitialized"
(confirmed locally that s/initialized/uninitialized/ fixes the error mentioned in Comment 2 and allows me to build)
Also, it looks like the existing patch (which I think is broken per comment 2 & comment 3) has already landed:
  http://hg.mozilla.org/integration/mozilla-inbound/rev/a477a8579ead
Whiteboard: [needs review]
Oh, and Mounir pushed a bustage fix after that to do the s/initialized/uninitialized/ already. Cool.  That bustage-fix was:
  http://hg.mozilla.org/integration/mozilla-inbound/rev/c2a85ff814c8
Summary: Do not fail build on -Winitialized when treating warnings as errors → Do not fail build on -Wuninitialized when treating warnings as errors
Target Milestone: --- → mozilla12
I seem to be hitting some weird "undefined symbol" issues on our Mac OS X tinderboxen, which (so far) always happen right after a -Wuninitialized warning is printed out.  I suspect (but am not sure) that it might be due to GCC 4.2 mishandling "-Werror -Wno-error=uninitialized".

Anyway, I filed bug 716787 on that.
https://hg.mozilla.org/mozilla-central/rev/a477a8579ead
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.