716541 - Do not fail build on -Wuninitialized when treating warnings as errors

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 1

[Mounir Lamouri (:mounir)]

This was requested during the discussion in dev-platform.

Comment 2

[Daniel Holbert [:dholbert]]

I think this needs s/initialized/uninitialized/

At least, right now when I build with this and FAIL_ON_WARNINGS=1 added in content/smil, I get the following build error when I hit content/smil:
> error: -Werror=initialized: no option -Winitialized

Also, "man g++" confirms that there's no "-Winitialized", but there is "-Wuninitialized"

Comment 3

[Daniel Holbert [:dholbert]]

(confirmed locally that s/initialized/uninitialized/ fixes the error mentioned in Comment 2 and allows me to build)

Comment 4

[Daniel Holbert [:dholbert]]

Also, it looks like the existing patch (which I think is broken per comment 2 & comment 3) has already landed:
  http://hg.mozilla.org/integration/mozilla-inbound/rev/a477a8579ead

Comment 5

[Daniel Holbert [:dholbert]]

Oh, and Mounir pushed a bustage fix after that to do the s/initialized/uninitialized/ already. Cool.  That bustage-fix was:
  http://hg.mozilla.org/integration/mozilla-inbound/rev/c2a85ff814c8

Comment 6

[Daniel Holbert [:dholbert]]

I seem to be hitting some weird "undefined symbol" issues on our Mac OS X tinderboxen, which (so far) always happen right after a -Wuninitialized warning is printed out.  I suspect (but am not sure) that it might be due to GCC 4.2 mishandling "-Werror -Wno-error=uninitialized".

Anyway, I filed bug 716787 on that.

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/a477a8579ead

Comment 8

[Marco Bonardo [:mak]]

and the followup
https://hg.mozilla.org/mozilla-central/rev/c2a85ff814c8