716561 - reevaluate which release mail gets sent to release-drivers

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

Someone recently asked to cut down on the amount of mail we send to this list for every release. We should re-evaluate what we send to the list, and remove ones that aren't required. For example, we no longer close the tree when tagging, so we don't need to inform the list of "tagging complete" anymore. We also probably don't need to send mail about mobile desktop builds being complete. We should chat with QA and drivers to figure out which mail is actually useful, and limit to that. All mail should continue to be sent to the release@ list.

Comment 1

[[e-mail] (:bhearsum)]

List of things we send mail for:
- Tagging started for both fennec and firefox
- Tagging complete for both fennec and firefox
- en-US build available for all of: linux-android, linux-mobile, macosx-mobile, win32-mobile, linux, linux64, win32, macosx64, linux xr, linux64 xr, win32 xr, macosx64 xr
- all builds available for all of: linux-mobile, macosx-mobile, win32-mobile, linux, linux64, win32, macosx64
- all signed builds available for both fennec and firefox
- updates available on betatest
- copied to releases directory
- ready for releasetest testing
- ready for release

I don't think any of the following are used by QA or drivers, and can therefore be dropped:
- Both tagging complete mails
- en-US build available for all XULRunner builds, plus all -mobile ones (which are mobile desktop builds)
- copied to releases directory

We also might be able to get rid of all of the "build available" and "all builds available" ones, because I _think_ QA waits for "all signed builds available. Do I have that right, Anthony? Are there any other mails that aren't useful to your group, or any that I've listed above that are?

I think we can also compress the "tagging started" mails into a single one.

Comment 2

[u279076]

Here is what I use for Desktop QA:
 - tagging started: signals creation of testplan in wiki
 - 1st en-US Desktop: signals creation of the Litmus testrun
 - en-US Mac, Linux32, Linux64, win32-unsigned: signals kick-off of automation
 - copied to releases directory: signals community/company dogfooding
 - updates available on betatest: signals manual update focused testing
 - ready for releasetest: signals update automation on releasetest
 - ready for release: signals update automation on release

Here is what I don't use:
 - signed builds available
 - all builds available
 - all XULRunner emails

Now the above list is not to say we could not live without the ones proposed by Ben in comment 1. We are but one voice and can roll with whatever is decided. We will simply just have to take cues from manually checking FTP.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Some sort of 'Release automation has started' is useful I think, since it's an ack to the go-to-build email. The tagging emails do that now but could be consolidated.

Comment 4

[[e-mail] (:bhearsum)]

Here's a sketch of what needs to be done:
* Rename PassRecipients to ImportantRecipients, since a large swath of builds that actually "pass" won't be mailed to these people.
* Remove the following builders from notify_builders: tagging, repack complete, xulrunner builds, push to mirrors
* Create a notifyPlatforms variable for the release config. Only enUSPlatforms listed in it should have their builders added to notify_builders.
* Remove the ImportantRecipients from the post_signing ChangeNotifier.

The relevant code is all scattered through: http://hg.mozilla.org/build/buildbotcustom/file/default/process/release.py. All of the release configs (*release-* from http://hg.mozilla.org/build/buildbot-configs/file/default/mozilla/) will need to updated for notifyPlatforms.

Erick, can you have a look at this?

Comment 5

[Alex Keybl [:akeybl]]

If we decide to move ahead with culling down the email volume, I'd still like to continue to receive the emails I'm currently getting. Will there be a separate list maintained?

Comment 6

[[e-mail] (:bhearsum)]

(In reply to Alex Keybl [:akeybl] from comment #5)
> If we decide to move ahead with culling down the email volume, I'd still
> like to continue to receive the emails I'm currently getting. Will there be
> a separate list maintained?

We can put you on an even more spammy list, if you want, but we won't be able to give you exactly what you have now. Is that an OK option, or should we try to find something better?

Comment 7

[Erick Dransch [:edransch]]

Attachment: patch to buildbotcustom

Comment 8

[Erick Dransch [:edransch]]

Attachment: patch to buildbot-configs/mozilla

Comment 9

[[e-mail] (:bhearsum)]

Comment on attachment 588803 [details] [diff] [review]
patch to buildbot-configs/mozilla

Review of attachment 588803 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the below fixes.

::: mozilla/release-fennec-mozilla-beta.py
@@ +2,4 @@
>  releaseConfig['disable_tinderbox_mail'] = True
>  
>  # Release Notification
> +releaseConfig['AllRecipients']       = ['[e-mail]','[e-mail]',]

Needs to be [e-mail].

::: mozilla/release-fennec-mozilla-release.py
@@ +2,5 @@
>  releaseConfig['disable_tinderbox_mail'] = True
>  
>  # Release Notification
> +releaseConfig['AllRecipients']       = ['[e-mail]','[e-mail]',]
> +releaseConfig['ImportantRecipients']      = ['[e-mail]',]

Nit: keep the equals sign and values lined up. This needs to be fixed in a few other places, too.

Comment 10

[[e-mail] (:bhearsum)]

Comment on attachment 588801 [details] [diff] [review]
patch to buildbotcustom

Review of attachment 588801 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 11

[Erick Dransch [:edransch]]

Attachment: patch to buildbot-configs/mozilla

Comment 12

[[e-mail] (:bhearsum)]

Comment on attachment 588885 [details] [diff] [review]
patch to buildbot-configs/mozilla

Whoops, I just realized you added akeybl to all of the configs, too - can you remove him from the staging ones? I don't think he wants that mail =)

Comment 13

[Erick Dransch [:edransch]]

Attachment: patch to buildbot-configs/mozilla

Remove akeybl from staging mailing lists

Comment 14

[Erick Dransch [:edransch]]

Attachment: patch to buildbotcustom

Merged with Rail's signing changes.

Comment 15

[[e-mail] (:bhearsum)]

Comment on attachment 589980 [details] [diff] [review]
patch to buildbotcustom

Review of attachment 589980 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

Comment 16

[Justin Wood (:Callek)]

(In reply to Ben Hearsum [:bhearsum] from comment #1)
> List of things we send mail for:
> - Tagging started for both fennec and firefox
> - Tagging complete for both fennec and firefox
...

> I don't think any of the following are used by QA or drivers, and can
> therefore be dropped:
> - Both tagging complete mails
> - en-US build available for all XULRunner builds, plus all -mobile ones
> (which are mobile desktop builds)
> - copied to releases directory

For me, copied to releases and tagging [start/finish] are both helpful, but I can find out both without the e-mails, they just help me in timing of SeaMonkey release work, especially on congested major-release-days.

Comment 17

[[e-mail] (:bhearsum)]

Merged to production today.