The default bug view has changed. See this FAQ.

Pressing back button in select form helper popup causes the first option to be selected

VERIFIED FIXED in Firefox 11

Status

()

Firefox for Android
General
P3
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: wesj)

Tracking

({testcase})

unspecified
Firefox 12
ARM
Android
testcase
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Steps to reproduce:
- Visit url testcase
- Tap on the first combobox
- Press the Android back button

Expected result:
- Option "Three" stays selected

Actual result:
- Option "One" becomes selected
Assignee: nobody → wjohnston
tracking-fennec: --- → 11+
Priority: -- → P3
(Assignee)

Comment 1

5 years ago
Created attachment 591264 [details] [diff] [review]
Patch

We return -1 here, and then we're trying to deselect everything in the list. This just makes us bail (no changes) when we get -1.
Attachment #591264 - Flags: review?(margaret.leibovic)

Comment 2

5 years ago
Comment on attachment 591264 [details] [diff] [review]
Patch

It's confusing that FormAssistant.show is only used for select elements. Maybe we can clean up FormAssistant at some point, but that's obviously not a priority right now.
Attachment #591264 - Flags: review?(margaret.leibovic) → review+
(Assignee)

Updated

5 years ago
Whiteboard: [inbound]
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9b12afb9724
https://hg.mozilla.org/mozilla-central/rev/f9b12afb9724
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 12
(Assignee)

Comment 5

5 years ago
Comment on attachment 591264 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): bug 695485
User impact if declined: potential data loss and annoyance
Testing completed (on m-c, etc.): landed jan 24
Risk to taking this patch (and alternatives if risky): low risk, uses a feature i already built but apparently didn't hook up
Attachment #591264 - Flags: approval-mozilla-aurora?
(Reporter)

Comment 6

5 years ago
Verified fixed in current Native trunk build.
Status: RESOLVED → VERIFIED

Comment 7

5 years ago
Comment on attachment 591264 [details] [diff] [review]
Patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #591264 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/3b0f39cd9d20
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.