Closed Bug 716595 Opened 8 years ago Closed 8 years ago

Pressing back button in select form helper popup causes the first option to be selected

Categories

(Firefox for Android :: General, defect, P3)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 12
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: martijn.martijn, Assigned: wesj)

References

()

Details

(Keywords: testcase)

Attachments

(1 file)

Steps to reproduce:
- Visit url testcase
- Tap on the first combobox
- Press the Android back button

Expected result:
- Option "Three" stays selected

Actual result:
- Option "One" becomes selected
Assignee: nobody → wjohnston
tracking-fennec: --- → 11+
Priority: -- → P3
Attached patch PatchSplinter Review
We return -1 here, and then we're trying to deselect everything in the list. This just makes us bail (no changes) when we get -1.
Attachment #591264 - Flags: review?(margaret.leibovic)
Comment on attachment 591264 [details] [diff] [review]
Patch

It's confusing that FormAssistant.show is only used for select elements. Maybe we can clean up FormAssistant at some point, but that's obviously not a priority right now.
Attachment #591264 - Flags: review?(margaret.leibovic) → review+
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/f9b12afb9724
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 12
Comment on attachment 591264 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): bug 695485
User impact if declined: potential data loss and annoyance
Testing completed (on m-c, etc.): landed jan 24
Risk to taking this patch (and alternatives if risky): low risk, uses a feature i already built but apparently didn't hook up
Attachment #591264 - Flags: approval-mozilla-aurora?
Verified fixed in current Native trunk build.
Status: RESOLVED → VERIFIED
Comment on attachment 591264 [details] [diff] [review]
Patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #591264 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.