716595 - Pressing back button in select form helper popup causes the first option to be selected

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Martijn Wargers (dead)]

Steps to reproduce:
- Visit url testcase
- Tap on the first combobox
- Press the Android back button

Expected result:
- Option "Three" stays selected

Actual result:
- Option "One" becomes selected

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

We return -1 here, and then we're trying to deselect everything in the list. This just makes us bail (no changes) when we get -1.

Comment 2

[:Margaret Leibovic]

Comment on attachment 591264 [details] [diff] [review]
Patch

It's confusing that FormAssistant.show is only used for select elements. Maybe we can clean up FormAssistant at some point, but that's obviously not a priority right now.

Comment 3

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9b12afb9724

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/f9b12afb9724

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 591264 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): bug 695485
User impact if declined: potential data loss and annoyance
Testing completed (on m-c, etc.): landed jan 24
Risk to taking this patch (and alternatives if risky): low risk, uses a feature i already built but apparently didn't hook up

Comment 6

[Martijn Wargers (dead)]

Verified fixed in current Native trunk build.

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 591264 [details] [diff] [review]
Patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3b0f39cd9d20