716619 - Simplify GC probes

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

The current probes implementation expects a GC to be either a full GC or a GC of a single compartment. We would like to allow multi-compartment GCs. This patch makes the probes a little weaker, but it gives us greater latitude to change the GC.

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 587059 [details] [diff] [review]
patch

Review of attachment 587059 [details] [diff] [review]:
-----------------------------------------------------------------

r+ assuming the !compartment vs !!compartment thing is correct

::: js/src/gc/Statistics.cpp
@@ +188,5 @@
>  
>      triggerReason = reason;
>  
>      beginPhase(PHASE_GC);
> +    Probes::GCStart(!compartment);

Shouldn't this be !!compartment?

@@ +265,5 @@
>  
>  void
>  Statistics::endGC()
>  {
> +    Probes::GCEnd(!compartment);

and this

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/77b82d0464b4

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff332e866e41

Relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca20586c4cd4

Comment 4

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/ca20586c4cd4