Last Comment Bug 716619 - Simplify GC probes
: Simplify GC probes
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla12
Assigned To: Bill McCloskey (:billm)
:
:
Mentors:
Depends on:
Blocks: 716142
  Show dependency treegraph
 
Reported: 2012-01-09 11:36 PST by Bill McCloskey (:billm)
Modified: 2012-02-02 11:07 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (8.58 KB, patch)
2012-01-09 11:36 PST, Bill McCloskey (:billm)
sphink: review+
Details | Diff | Splinter Review

Description Bill McCloskey (:billm) 2012-01-09 11:36:19 PST
Created attachment 587059 [details] [diff] [review]
patch

The current probes implementation expects a GC to be either a full GC or a GC of a single compartment. We would like to allow multi-compartment GCs. This patch makes the probes a little weaker, but it gives us greater latitude to change the GC.
Comment 1 Steve Fink [:sfink] [:s:] 2012-01-09 11:53:50 PST
Comment on attachment 587059 [details] [diff] [review]
patch

Review of attachment 587059 [details] [diff] [review]:
-----------------------------------------------------------------

r+ assuming the !compartment vs !!compartment thing is correct

::: js/src/gc/Statistics.cpp
@@ +188,5 @@
>  
>      triggerReason = reason;
>  
>      beginPhase(PHASE_GC);
> +    Probes::GCStart(!compartment);

Shouldn't this be !!compartment?

@@ +265,5 @@
>  
>  void
>  Statistics::endGC()
>  {
> +    Probes::GCEnd(!compartment);

and this
Comment 4 Joe Drew (not getting mail) 2012-01-28 19:01:28 PST
https://hg.mozilla.org/mozilla-central/rev/ca20586c4cd4

Note You need to log in before you can comment on or make changes to this bug.