Simplify GC probes

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

unspecified
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 587059 [details] [diff] [review]
patch

The current probes implementation expects a GC to be either a full GC or a GC of a single compartment. We would like to allow multi-compartment GCs. This patch makes the probes a little weaker, but it gives us greater latitude to change the GC.
Attachment #587059 - Flags: review?(sphink)
(Assignee)

Updated

6 years ago
Blocks: 716142
Comment on attachment 587059 [details] [diff] [review]
patch

Review of attachment 587059 [details] [diff] [review]:
-----------------------------------------------------------------

r+ assuming the !compartment vs !!compartment thing is correct

::: js/src/gc/Statistics.cpp
@@ +188,5 @@
>  
>      triggerReason = reason;
>  
>      beginPhase(PHASE_GC);
> +    Probes::GCStart(!compartment);

Shouldn't this be !!compartment?

@@ +265,5 @@
>  
>  void
>  Statistics::endGC()
>  {
> +    Probes::GCEnd(!compartment);

and this
Attachment #587059 - Flags: review?(sphink) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/77b82d0464b4
Target Milestone: --- → mozilla12
(Assignee)

Comment 3

6 years ago
Backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff332e866e41

Relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca20586c4cd4
https://hg.mozilla.org/mozilla-central/rev/ca20586c4cd4
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.