Last Comment Bug 716629 - Mark deleted JSFunction methods as private
: Mark deleted JSFunction methods as private
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla12
Assigned To: general
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-09 12:13 PST by Jim Blandy :jimb
Modified: 2012-01-10 01:41 PST (History)
2 users (show)
jimb: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Mark deleted JSFunction::toFunction methods as private, as per MOZ_DELETE instructions in mfbt/Attributes.h. (506 bytes, patch)
2012-01-09 12:13 PST, Jim Blandy :jimb
jwalden+bmo: review+
Details | Diff | Splinter Review

Description Jim Blandy :jimb 2012-01-09 12:13:03 PST
Created attachment 587070 [details] [diff] [review]
Mark deleted JSFunction::toFunction methods as private, as per MOZ_DELETE instructions in mfbt/Attributes.h.

The documentation for MOZ_DELETE in mfbt/Attributes.h says:

 * MOZ_DELETE relies on C++11 functionality not universally implemented.  As a
 * backstop, method declarations using MOZ_DELETE should be private.

My changeset 89c6efec31a7 of 2012-1-6 added MOZ_DELETE, but didn't mark the methods private. The attached patch fixes this.
Comment 2 Marco Bonardo [::mak] 2012-01-10 01:41:00 PST
https://hg.mozilla.org/mozilla-central/rev/c7e4fd6cd6a4

Note You need to log in before you can comment on or make changes to this bug.