Mark deleted JSFunction methods as private

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jimb, Unassigned)

Tracking

unspecified
mozilla12
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 587070 [details] [diff] [review]
Mark deleted JSFunction::toFunction methods as private, as per MOZ_DELETE instructions in mfbt/Attributes.h.

The documentation for MOZ_DELETE in mfbt/Attributes.h says:

 * MOZ_DELETE relies on C++11 functionality not universally implemented.  As a
 * backstop, method declarations using MOZ_DELETE should be private.

My changeset 89c6efec31a7 of 2012-1-6 added MOZ_DELETE, but didn't mark the methods private. The attached patch fixes this.
Attachment #587070 - Flags: review?(jwalden+bmo)
Attachment #587070 - Flags: review?(jwalden+bmo) → review+
(Reporter)

Comment 1

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7e4fd6cd6a4
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/c7e4fd6cd6a4
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.