Closed Bug 716629 Opened 13 years ago Closed 13 years ago

Mark deleted JSFunction methods as private

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla12

People

(Reporter: jimb, Unassigned)

Details

Attachments

(1 file)

Mark deleted JSFunction::toFunction methods as private, as per MOZ_DELETE instructions in mfbt/Attributes.h.
506 bytes, patch
Waldo
: review+
Details | Diff | Splinter Review 
The documentation for MOZ_DELETE in mfbt/Attributes.h says:

 * MOZ_DELETE relies on C++11 functionality not universally implemented.  As a
 * backstop, method declarations using MOZ_DELETE should be private.

My changeset 89c6efec31a7 of 2012-1-6 added MOZ_DELETE, but didn't mark the methods private. The attached patch fixes this.
Attachment #587070 - Flags: review?(jwalden+bmo)
Attachment #587070 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7e4fd6cd6a4
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/c7e4fd6cd6a4
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: