Closed Bug 716677 Opened 8 years ago Closed 8 years ago

test_bug296375.xul makes incorrect assumptions about the event ordering

Categories

(Core :: DOM: Events, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

This test implicitly assumes that events added in order will be fired in order.  We should just call finish when we know that we're done.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #587138 - Flags: review?(bugs)
Comment on attachment 587138 [details] [diff] [review]
Patch (v1)

Does addLoadEvent not guarantee the right order? That would be bug in
mochitest. addEventListener does guarantee the order. Is mochitest not using that?

But anyway, looks ok.
Attachment #587138 - Flags: review?(bugs) → review+
No, mochitest rolls its own implementation, IIRC.
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b4c5610aa69
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/2b4c5610aa69
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.