Last Comment Bug 716677 - test_bug296375.xul makes incorrect assumptions about the event ordering
: test_bug296375.xul makes incorrect assumptions about the event ordering
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Events (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla12
Assigned To: :Ehsan Akhgari (busy, don't ask for review please)
:
Mentors:
Depends on:
Blocks: 668728
  Show dependency treegraph
 
Reported: 2012-01-09 14:15 PST by :Ehsan Akhgari (busy, don't ask for review please)
Modified: 2012-01-10 20:33 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (804 bytes, patch)
2012-01-09 14:17 PST, :Ehsan Akhgari (busy, don't ask for review please)
bugs: review+
Details | Diff | Review

Description :Ehsan Akhgari (busy, don't ask for review please) 2012-01-09 14:15:52 PST
This test implicitly assumes that events added in order will be fired in order.  We should just call finish when we know that we're done.
Comment 1 :Ehsan Akhgari (busy, don't ask for review please) 2012-01-09 14:17:16 PST
Created attachment 587138 [details] [diff] [review]
Patch (v1)
Comment 2 Olli Pettay [:smaug] 2012-01-10 07:04:44 PST
Comment on attachment 587138 [details] [diff] [review]
Patch (v1)

Does addLoadEvent not guarantee the right order? That would be bug in
mochitest. addEventListener does guarantee the order. Is mochitest not using that?

But anyway, looks ok.
Comment 3 :Ehsan Akhgari (busy, don't ask for review please) 2012-01-10 09:41:08 PST
No, mochitest rolls its own implementation, IIRC.
Comment 4 :Ehsan Akhgari (busy, don't ask for review please) 2012-01-10 09:44:41 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b4c5610aa69
Comment 5 :Ehsan Akhgari (busy, don't ask for review please) 2012-01-10 20:33:44 PST
https://hg.mozilla.org/mozilla-central/rev/2b4c5610aa69

Note You need to log in before you can comment on or make changes to this bug.