The default bug view has changed. See this FAQ.

Add FAIL_ON_WARNINGS in some SVG/SMIL directories

RESOLVED FIXED in mozilla12

Status

()

Core
SVG
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Now that bug 703121 has landed, we can start labeling gcc-warning-free directories as FAIL_ON_WARNINGS, to keep them warning-free.

I'm filing this bug on adding this label for already-warning-free SVG-related directories, which I believe to be the following:
 content/smil
 content/svg/document/src/
 layout/svg/base/src/

(I'm not including content/svg/content because I seem to recall it having a few GCC warnings, but I'll double-check that and include it if it's warning-free.)
(Assignee)

Comment 1

5 years ago
(In reply to Daniel Holbert [:dholbert] from comment #0)
> (I'm not including content/svg/content because I seem to recall it having a
> few GCC warnings, but I'll double-check that and include it if it's
> warning-free.)

Confirmed -- I tried building with warnings-as-errors on in content/svg/content (using g++ 4.6.2), and hit this:
> nsSVGFilters.cpp:3794:21: error: variable ‘yExt’ set but not used [-Werror=unused-but-set-variable]
(there could easily be more warnings as well; this is just the first one I hit)

So, I won't concern myself with content/svg for the purposes of this bug. (at least not yet)
(Assignee)

Comment 2

5 years ago
Created attachment 587191 [details] [diff] [review]
patch v1

This patch covers the 3 directories mentioned in comment 1.  I've confirmed locally that it works (no errors) in a debug build, and I'm most of the way through a successful opt build.

Just pushed to TryServer for mac/linux/android (our warnings-as-errors-enabled platforms), too:
 https://tbpl.mozilla.org/?tree=Try&rev=5fb8ea0712d7
(Assignee)

Comment 3

5 years ago
Comment on attachment 587191 [details] [diff] [review]
patch v1

This can't land until we've sorted out a mysterious Mac OS X build failure in bug 716787.  However, aside from that, it's ready for review.
Attachment #587191 - Flags: review?(jwatt)
Comment on attachment 587191 [details] [diff] [review]
patch v1

Sweet!
Attachment #587191 - Flags: review?(jwatt) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b121ed2a5db6
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla12
Backed out of inbound for "[mangled variable name]$non_lazy_ptr can't be undefined in a subtraction expression" a la bug 716787.

https://hg.mozilla.org/integration/mozilla-inbound/rev/4202e19f36e2
Target Milestone: mozilla12 → ---
(Assignee)

Comment 7

5 years ago
Looks like it just needed a clobber for bug 716787 to kick in and allow this to be non-red.
Re-landed:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/1d1938bb244d
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/1d1938bb244d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.