716702 - jsopcode.h:661:5: warning: C++ style comments are not allowed in ISO C90

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

Filing bug on this build warning, which we get many copies of (since this header seems to be include in a lot of files):
{
jsopcode.h:661:5: warning: C++ style comments are not allowed in ISO C90 [enabled by default]
jsopcode.h:661:5: warning: (this will be reported only once per input file) [enabled by default]
}

This warning is for this line:
> 663    // Boolean conversion, for 'if (counters) ...'
http://mxr.mozilla.org/mozilla-central/source/js/src/jsopcode.h#663
which was added in http://hg.mozilla.org/mozilla-central/rev/de66e7bd2b98 for bug 687134.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

This changes the comment to be /* .... */ instead of //

though I seem to recall JS engine preferring this style:
 /*
  * comment
  */
Happy to change it to that form if that's better; just let me know.

Comment 2

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7dde51205d24

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/7dde51205d24