Note: There are a few cases of duplicates in user autocompletion which are being worked on.

jsopcode.h:661:5: warning: C++ style comments are not allowed in ISO C90

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla12
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Filing bug on this build warning, which we get many copies of (since this header seems to be include in a lot of files):
{
jsopcode.h:661:5: warning: C++ style comments are not allowed in ISO C90 [enabled by default]
jsopcode.h:661:5: warning: (this will be reported only once per input file) [enabled by default]
}

This warning is for this line:
> 663    // Boolean conversion, for 'if (counters) ...'
http://mxr.mozilla.org/mozilla-central/source/js/src/jsopcode.h#663
which was added in http://hg.mozilla.org/mozilla-central/rev/de66e7bd2b98 for bug 687134.
(Assignee)

Comment 1

6 years ago
Created attachment 587167 [details] [diff] [review]
fix

This changes the comment to be /* .... */ instead of //

though I seem to recall JS engine preferring this style:
 /*
  * comment
  */
Happy to change it to that form if that's better; just let me know.
Assignee: general → dholbert
Status: NEW → ASSIGNED
Attachment #587167 - Flags: review?(bhackett1024)
Attachment #587167 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7dde51205d24
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/7dde51205d24
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.