716722 - Clear the correct request.remember prefs in sanitize.js

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

In bug 580576, we switched from using normal prefs to using content prefs for storing request.remember information, but we didn't update sanitize.js.

We should make sure we're not messing this up in other places, but we at least need to change this to use Services.contentPrefs: http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/sanitize.js#134.

Comment 1

[:Margaret Leibovic]

Attachment: patch

Turns out we can just get rid of that line, since we're already clearing all content prefs here: http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/sanitize.js#153.

I also went through and fixed places where we could use Services.jsm (these APIs must have been added since a first pass was made to use Services.jsm).

Comment 2

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2676737a824c

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/2676737a824c

Comment 4

[:Margaret Leibovic]

This is just some code cleanup, and I don't think it will bit-rot anyone, so it doesn't need to land on Aurora.