Closed Bug 716722 Opened 8 years ago Closed 8 years ago

Clear the correct request.remember prefs in sanitize.js

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 12

People

(Reporter: Margaret, Assigned: Margaret)

Details

(Whiteboard: [not-fennec-11])

Attachments

(1 file)

In bug 580576, we switched from using normal prefs to using content prefs for storing request.remember information, but we didn't update sanitize.js.

We should make sure we're not messing this up in other places, but we at least need to change this to use Services.contentPrefs: http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/sanitize.js#134.
Attached patch patchSplinter Review
Turns out we can just get rid of that line, since we're already clearing all content prefs here: http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/sanitize.js#153.

I also went through and fixed places where we could use Services.jsm (these APIs must have been added since a first pass was made to use Services.jsm).
Assignee: nobody → margaret.leibovic
Status: NEW → ASSIGNED
Attachment #587185 - Flags: review?(mbrubeck)
Attachment #587185 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/mozilla-central/rev/2676737a824c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
This is just some code cleanup, and I don't think it will bit-rot anyone, so it doesn't need to land on Aurora.
Whiteboard: [not-fennec-11]
You need to log in before you can comment on or make changes to this bug.