716754 - Crash when accessing navigator.mozTelephony from chrome page

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Philipp von Weitershausen [:philikon]]

Right now we crash in NS_NewTelephony() if the page accessing navigator.mozTelephony is a chrome page because document->NodePrincipal()->GetURI() returns a null URI (the principal is the system principal).

Comment 1

[Philipp von Weitershausen [:philikon]]

I wouldn't say there's anything critical about this since (a) navigator.mozTelephony is not part of any normal Firefox build and (b) B2G's Gaia UI doesn't use chrome at all.

Comment 2

[Scoobidiver (away)]

Criticality and priority are two different things.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

This has r=sicking.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v2

We decided to allow chrome access always.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4abbedf5b4ca

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/4abbedf5b4ca