716811 - Local DB calls getAsBoolean for IS_FOLDER, schema uses integers, ClassCastException results.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

01-09 23:09:46.828 E/ContentValues(10750): Cannot cast value for folder to a Boolean: 0
01-09 23:09:46.828 E/ContentValues(10750): java.lang.ClassCastException: java.lang.Integer
01-09 23:09:46.828 E/ContentValues(10750): 	at android.content.ContentValues.getAsBoolean(ContentValues.java:413)
01-09 23:09:46.828 E/ContentValues(10750): 	at org.mozilla.fennec_rnewman.db.BrowserProvider.insertInTransaction(BrowserProvider.java:695)
01-09 23:09:46.828 E/ContentValues(10750): 	at org.mozilla.fennec_rnewman.db.BrowserProvider.insert(BrowserProvider.java:662)

Comment 1

[Richard Newman [:rnewman]]

Looks like this is actually a Fennec bug. Pretty high priority; this blocks further testing of bookmarks sync.

(Well, so does "turn on local DB support", but I'm working around that :D)

lucasr, this one for you?


        private void createMobileBookmarksFolder(SQLiteDatabase db) {
            ContentValues values = new ContentValues();
            values.put(Bookmarks.GUID, Bookmarks.MOBILE_FOLDER_GUID);
            values.put(Bookmarks.IS_FOLDER, 1);
            values.put(Bookmarks.POSITION, 0);

and

            db.execSQL("CREATE TABLE " + TABLE_BOOKMARKS + "(" +
                    Bookmarks._ID + " INTEGER PRIMARY KEY AUTOINCREMENT," +
                    Bookmarks.TITLE + " TEXT," +
                    Bookmarks.URL + " TEXT," +
                    Bookmarks.IS_FOLDER + " INTEGER NOT NULL DEFAULT 0," +


versus the line that fails:

                String url = values.getAsString(Bookmarks.URL);
                ContentValues imageValues = extractImageValues(values, url);
                Boolean isFolder = values.getAsBoolean(Bookmarks.IS_FOLDER);

This should probably be

                Boolean isFolder = values.getAsInteger(Bookmarks.IS_FOLDER) == 1;

I don't know if the getAsBoolean version works elsewhere, but apparently it doesn't on Android 2.3.4 on the Galaxy S2.

Comment 2

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v1

Haven't tested this yet (blocked on another bug, and it's getting late), but it looks right...!

Comment 3

[Richard Newman [:rnewman]]

Inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/d33ae3516305

Thanks for the quick turnaround, Brad.

Note to self: flag for Aurora approval when this lands.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d33ae3516305

Comment 5

[Lucas Rocha (:lucasr)]

Comment on attachment 587252 [details] [diff] [review]
Proposed patch. v1

Review of attachment 587252 [details] [diff] [review]:
-----------------------------------------------------------------

This patch causes a NullPointerException when adding bookmarks. I submitted a patch in bug 707150 to fix that (given that the patch is already in mozilla-central). I think we should skip this patch from aurora and a slightly different version of my patch in bug 707150 instead.

Comment 6

[Richard Newman [:rnewman]]

(In reply to Lucas Rocha (:lucasr) from comment #5)

> I think we should skip this patch from aurora and a
> slightly different version of my patch in bug 707150 instead.

Agreed!

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

If this isn't going to aurora, please mark the whiteboard not-fennec-11

Comment 8

[Richard Newman [:rnewman]]

Lucas, did your fix get to Aurora yet?

Comment 9

[Lucas Rocha (:lucasr)]

This has already been fixed in Aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/15bbd03602a4