potential race condition in GeckoThread

RESOLVED FIXED in Firefox 11

Status

()

Product:
Firefox for Android
Component:
General
Type:
defect
Status:
RESOLVED FIXED
Opened:
8 years ago
Updated:
8 years ago

People

(Reporter: blassey, Assigned: blassey)

Tracking

Version:
unspecified
Target:
Firefox 12
Platform:
x86
macOS
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

patch
1.92 KB, patch
mfinkle
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Assignee

Description

•
8 years ago
Posted patch patch — — Splinter Review 
mBrowserToolbar initialized isn't created until after the GeckoThread is created and started, but it is used in GeckoThread.run().
Attachment #587255 - Flags: review?(mark.finkle)
Attachment #587255 - Flags: review?(mark.finkle) → review+
 Assignee

Comment 2

•
8 years ago 
Comment on attachment 587255 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
very slight possibilty that mBrowserToolbar will be null when its used in GeckoThread
Testing completed (on m-c, etc.): 
on inbound now
Risk to taking this patch (and alternatives if risky):
Fairly low risk, just re-ordering code
Attachment #587255 - Flags: approval-mozilla-aurora?

Comment 3

•
8 years ago 
Leaving in the queue until this has landed on m-c and baked for a day.

Comment 4

•
8 years ago 
https://hg.mozilla.org/mozilla-central/rev/e10473f947bf
Assignee: nobody → blassey.bugs
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12

Comment 5

•
8 years ago 
Comment on attachment 587255 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approving for Aurora.
Attachment #587255 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.