Closed
Bug 716818
Opened 11 years ago
Closed 11 years ago
potential race condition in GeckoThread
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox11 fixed, firefox12 fixed)
RESOLVED
FIXED
Firefox 12
People
(Reporter: blassey, Assigned: blassey)
Details
(Whiteboard: [inbound])
Attachments
(1 file)
1.92 KB,
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
mBrowserToolbar initialized isn't created until after the GeckoThread is created and started, but it is used in GeckoThread.run().
Attachment #587255 -
Flags: review?(mark.finkle)
Updated•11 years ago
|
Attachment #587255 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e10473f947bf
Whiteboard: [inbound]
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 587255 [details] [diff] [review] patch [Approval Request Comment] Regression caused by (bug #): User impact if declined: very slight possibilty that mBrowserToolbar will be null when its used in GeckoThread Testing completed (on m-c, etc.): on inbound now Risk to taking this patch (and alternatives if risky): Fairly low risk, just re-ordering code
Attachment #587255 -
Flags: approval-mozilla-aurora?
Comment 3•11 years ago
|
||
Leaving in the queue until this has landed on m-c and baked for a day.
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e10473f947bf
Assignee: nobody → blassey.bugs
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment 5•11 years ago
|
||
Comment on attachment 587255 [details] [diff] [review] patch [Triage Comment] Mobile only - approving for Aurora.
Attachment #587255 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 6•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/42991a0d76fb
status-firefox11:
--- → fixed
status-firefox12:
--- → fixed
Updated•2 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•