Closed Bug 716818 Opened 9 years ago Closed 9 years ago

potential race condition in GeckoThread

Categories

(Firefox for Android :: General, defect)

Product:
Firefox for Android
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 12
Tracking Flags:
Tracking Status
firefox11 --- fixed
firefox12 --- fixed

People

(Reporter: blassey, Assigned: blassey)

Details

(Whiteboard: [inbound])

Attachments

(1 file)

patch
1.92 KB, patch
mfinkle
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
mBrowserToolbar initialized isn't created until after the GeckoThread is created and started, but it is used in GeckoThread.run().
Attachment #587255 - Flags: review?(mark.finkle)
Attachment #587255 - Flags: review?(mark.finkle) → review+
Comment on attachment 587255 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
very slight possibilty that mBrowserToolbar will be null when its used in GeckoThread
Testing completed (on m-c, etc.): 
on inbound now
Risk to taking this patch (and alternatives if risky):
Fairly low risk, just re-ordering code
Attachment #587255 - Flags: approval-mozilla-aurora?
Leaving in the queue until this has landed on m-c and baked for a day.
https://hg.mozilla.org/mozilla-central/rev/e10473f947bf
Assignee: nobody → blassey.bugs
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 587255 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approving for Aurora.
Attachment #587255 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.