716818 - potential race condition in GeckoThread

Status: RESOLVED FIXED

Description

[Brad Lassey [:blassey] (use needinfo?)]

Created attachment 587255 [details] [diff] [review]
patch

mBrowserToolbar initialized isn't created until after the GeckoThread is created and started, but it is used in GeckoThread.run().

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e10473f947bf

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 587255 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
very slight possibilty that mBrowserToolbar will be null when its used in GeckoThread
Testing completed (on m-c, etc.): 
on inbound now
Risk to taking this patch (and alternatives if risky):
Fairly low risk, just re-ordering code

Comment 3

[Alex Keybl [:akeybl]]

Leaving in the queue until this has landed on m-c and baked for a day.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e10473f947bf

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 587255 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approving for Aurora.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/42991a0d76fb