Note: There are a few cases of duplicates in user autocompletion which are being worked on.

blogspot.com pages are not properly framed after page is scrolled

VERIFIED FIXED in Firefox 11

Status

()

Firefox for Android
General
P1
normal
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: Carla Nadastean, Assigned: kats)

Tracking

12 Branch
Firefox 12
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 verified, fennec11+)

Details

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Created attachment 587284 [details]
screenshot

Build: 12.0a1 (2012-01-09) Device: HTC Desire Z (Android 2.3)

Steps to reproduce:
1. Go to http://android-developers.blogspot.com/2011/07/debugging-android-jni-with-checkjni.html
2. Try to scroll from the bottom of the page.

Expected Result:
Page content is scrolled successfully.

Actual Result:
Page content is scrolled but the page is no longer properly framed. (screenshot attached)
(Reporter)

Comment 1

6 years ago
Reproducible also on Aurora:
11.0a2 (2012-01-09) HTC Desire Z (Android 2.3)
status-firefox11: --- → affected
status-firefox12: --- → affected
Assignee: nobody → bugmail.mozilla
tracking-fennec: --- → ?
tracking-fennec: ? → 11+
Priority: -- → P2
I looked at this a bit, and it seems to be happening because the subdocument scrolling code in browser.js takes over partway through the pan, so we get a little bit of panning (possibly into overscroll) in PZC, and then the iframe pans the rest of the touch movement. When the touch move stops, we don't bounce back because we're still sending the movement to the subdocument scroller.
Duplicate of this bug: 719019
Duplicate of this bug: 717138
Priority: P2 → P1
Created attachment 590225 [details] [diff] [review]
(1/2) Bounce back if overscrolled after flinging subdocument

It only gets into this state if you touch down on a subdocument and pan/fling before the Gesture:ShowPress/Panning:Override event round-trip has time to complete.
Attachment #590225 - Flags: review?(chrislord.net)
Created attachment 590227 [details] [diff] [review]
(2/2) Abort subdocument fling runnable when the subdoc stops scrolling

This is just so that the bounce-back happens faster if you happen to fling a subdoc very aggressively when you're already near the edge of the subdoc. Without this it could take a few seconds for the bounce-back to happen because it has to wait for the fling runnable to exhaust itself even though it's not visibly moving anything.
Attachment #590227 - Flags: review?(chrislord.net)

Comment 7

6 years ago
Comment on attachment 590225 [details] [diff] [review]
(1/2) Bounce back if overscrolled after flinging subdocument

Review of attachment 590225 [details] [diff] [review]:
-----------------------------------------------------------------

Looks alright to me.
Attachment #590225 - Flags: review?(chrislord.net) → review+

Comment 8

6 years ago
Comment on attachment 590227 [details] [diff] [review]
(2/2) Abort subdocument fling runnable when the subdoc stops scrolling

Review of attachment 590227 [details] [diff] [review]:
-----------------------------------------------------------------

Also looks good.
Attachment #590227 - Flags: review?(chrislord.net) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5f5c1c96f4e
https://hg.mozilla.org/integration/mozilla-inbound/rev/e862a60fdb13
status-firefox12: affected → fixed
Target Milestone: --- → Firefox 12
https://hg.mozilla.org/mozilla-central/rev/e5f5c1c96f4e
https://hg.mozilla.org/mozilla-central/rev/e862a60fdb13
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Comment on attachment 590225 [details] [diff] [review]
(1/2) Bounce back if overscrolled after flinging subdocument

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: It's possible to get stuck in overscroll after panning an iframe
Testing completed (on m-c, etc.): On m-c
Risk to taking this patch (and alternatives if risky): Potentially regression in fling behaviour
Attachment #590225 - Flags: approval-mozilla-aurora?
Comment on attachment 590227 [details] [diff] [review]
(2/2) Abort subdocument fling runnable when the subdoc stops scrolling

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: If you fling a subdocument really hard and it hits the end and stops scrolling, the overall page may still remain in overscroll for a few more seconds rather than bouncing back immediately
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): potentially regressions in subdocument scrolling.
Attachment #590227 - Flags: approval-mozilla-aurora?
Verified fixed in current Native trunk build on the LG Optimus Black, Android 2.2.2.
Status: RESOLVED → VERIFIED
Comment on attachment 590225 [details] [diff] [review]
(1/2) Bounce back if overscrolled after flinging subdocument

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #590225 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

6 years ago
Attachment #590227 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/b32116534dc2
status-firefox11: affected → fixed
status-firefox12: fixed → verified
(and the other patch landed on Aurora at the same time)
https://hg.mozilla.org/releases/mozilla-aurora/rev/bd5c7b73ce79
You need to log in before you can comment on or make changes to this bug.