Closed Bug 716863 Opened 10 years ago Closed 10 years ago

blogspot.com pages are not properly framed after page is scrolled

Categories

(Firefox for Android Graveyard :: General, defect, P1)

12 Branch
ARM
Android
defect

Tracking

(firefox11 fixed, firefox12 verified, fennec11+)

VERIFIED FIXED
Firefox 12
Tracking Status
firefox11 --- fixed
firefox12 --- verified
fennec 11+ ---

People

(Reporter: carla.nadastean, Assigned: kats)

References

Details

Attachments

(3 files)

Attached image screenshot
Build: 12.0a1 (2012-01-09) Device: HTC Desire Z (Android 2.3)

Steps to reproduce:
1. Go to http://android-developers.blogspot.com/2011/07/debugging-android-jni-with-checkjni.html
2. Try to scroll from the bottom of the page.

Expected Result:
Page content is scrolled successfully.

Actual Result:
Page content is scrolled but the page is no longer properly framed. (screenshot attached)
Reproducible also on Aurora:
11.0a2 (2012-01-09) HTC Desire Z (Android 2.3)
Assignee: nobody → bugmail.mozilla
tracking-fennec: --- → ?
tracking-fennec: ? → 11+
Priority: -- → P2
I looked at this a bit, and it seems to be happening because the subdocument scrolling code in browser.js takes over partway through the pan, so we get a little bit of panning (possibly into overscroll) in PZC, and then the iframe pans the rest of the touch movement. When the touch move stops, we don't bounce back because we're still sending the movement to the subdocument scroller.
Duplicate of this bug: 719019
Duplicate of this bug: 717138
Priority: P2 → P1
It only gets into this state if you touch down on a subdocument and pan/fling before the Gesture:ShowPress/Panning:Override event round-trip has time to complete.
Attachment #590225 - Flags: review?(chrislord.net)
This is just so that the bounce-back happens faster if you happen to fling a subdoc very aggressively when you're already near the edge of the subdoc. Without this it could take a few seconds for the bounce-back to happen because it has to wait for the fling runnable to exhaust itself even though it's not visibly moving anything.
Attachment #590227 - Flags: review?(chrislord.net)
Comment on attachment 590225 [details] [diff] [review]
(1/2) Bounce back if overscrolled after flinging subdocument

Review of attachment 590225 [details] [diff] [review]:
-----------------------------------------------------------------

Looks alright to me.
Attachment #590225 - Flags: review?(chrislord.net) → review+
Comment on attachment 590227 [details] [diff] [review]
(2/2) Abort subdocument fling runnable when the subdoc stops scrolling

Review of attachment 590227 [details] [diff] [review]:
-----------------------------------------------------------------

Also looks good.
Attachment #590227 - Flags: review?(chrislord.net) → review+
Comment on attachment 590225 [details] [diff] [review]
(1/2) Bounce back if overscrolled after flinging subdocument

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: It's possible to get stuck in overscroll after panning an iframe
Testing completed (on m-c, etc.): On m-c
Risk to taking this patch (and alternatives if risky): Potentially regression in fling behaviour
Attachment #590225 - Flags: approval-mozilla-aurora?
Comment on attachment 590227 [details] [diff] [review]
(2/2) Abort subdocument fling runnable when the subdoc stops scrolling

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: If you fling a subdocument really hard and it hits the end and stops scrolling, the overall page may still remain in overscroll for a few more seconds rather than bouncing back immediately
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): potentially regressions in subdocument scrolling.
Attachment #590227 - Flags: approval-mozilla-aurora?
Verified fixed in current Native trunk build on the LG Optimus Black, Android 2.2.2.
Status: RESOLVED → VERIFIED
Comment on attachment 590225 [details] [diff] [review]
(1/2) Bounce back if overscrolled after flinging subdocument

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #590225 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #590227 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(and the other patch landed on Aurora at the same time)
https://hg.mozilla.org/releases/mozilla-aurora/rev/bd5c7b73ce79
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.