717025 - nsHTMLTableElement.cpp:709:12: error: variable ‘rv’ set but not used [-Werror=unused-but-set-variable]

Status: RESOLVED DUPLICATE of bug 716904

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert]]

Bug 716338 turned on warnings-as-errors in content/html/content/src/Makefile.in

This breaks my local build (with --enable-warnings-as-errors), due to this build warning:
{
nsHTMLTableElement.cpp:709:12: error: variable ‘rv’ set but not used [-Werror=unused-but-set-variable]
}

Here's the lifetime of the variable in question:
> 679 NS_IMETHODIMP
> 680 nsHTMLTableElement::InsertRow(PRInt32 aIndex, nsIDOMHTMLElement** aValue)
> 681 {
[...]
> 709   nsresult rv;
[...]
> 738         rv = parent->AppendChild(newRowNode, getter_AddRefs(retChild));
[...]
> 743         rv = parent->InsertBefore(newRowNode, refRow,
> 744                                   getter_AddRefs(retChild));
[...]
> 780         rv = AppendChildTo(newRowGroup, true);
[...]
> 817   return NS_OK;
> 818 }

As the warning indicates, we set it a bunch of times but never bother to check it.