Closed
Bug 717047
Opened 14 years ago
Closed 14 years ago
Use cmath instead of math.h in nsMathUtils.h
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: joe, Assigned: joe)
Details
Attachments
(1 file, 1 obsolete file)
|
1.03 KB,
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
If we manage to include <cmath> before including nsMathUtils.h, its usage of isfinite() breaks because isfinite only exists in the std:: namespace. We can work around this by explicitly using <cmath>'s version of the function.
Attachment #587476 -
Flags: review?(bjacob)
|
Assignee | |
Comment 1•14 years ago
|
||
We shouldnt do "using namespace std;" in a header. I'm going to run this through try, but it seems like all I need to worry about is std::isfinite on Darwin.
Attachment #587476 -
Attachment is obsolete: true
Attachment #587476 -
Flags: review?(bjacob)
Attachment #587503 -
Flags: review?(bjacob)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 587503 [details] [diff] [review]
use cmath v2
Review of attachment 587503 [details] [diff] [review]:
-----------------------------------------------------------------
r+ \o/ \o/ \o/
Attachment #587503 -
Flags: review?(bjacob) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•