717135 - add robocop extension to talos for robotium tpan

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Shriram (irc: Mavericks)]

we have roboextender as an extension in mochitest with robotium, and in order to make tpan work and access data from fennec chrome apis, we need to include the roboextender extension in remote android talos

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

I wish there was a way to sync this between both repositories.  For now I will just add this to the mobile_profile directory as an extension and we will have to work on keeping the two synchronized.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

the robocop changes are landed and now we need a talos patch to resolve this.  I have one in the works and should have it by tomorrow.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: talos tweaks to get robocop tests to run (1.0)

this patches has a few components:
 * adds a --fennecIDs  to remotePerfConfigurator.py (keys off this for robocop stuff)
 * during config file writing we replace 'class org.mozilla.fennec' with 'class %(browser_path)s'
 * during ttest.py::runTest, after creating the profile, we setup robocop by creating the two files (robotium.config and fennec_ids.txt) on the device
 * hacks up the generateBrowserCommandLine to use the raw url for the command line iff it starts with 'am instrument'.  yes this is an overloaded value for url, but then again, so is the tp stuff:)

note to releng: this requires us to have a fennec_ids.txt file somewhere in the food chain that we can point talos at.  We need to discuss where you might already have this file lying around or the best place to get it.

Comment 4

[Jeff Hammel]

Comment on attachment 594893 [details] [diff] [review]
talos tweaks to get robocop tests to run (1.0)

+        # For the robocop tests they use 'am instrument ...' and do not launch fennec or a url proper
+        if url.find('am instrument') == 0:
+            return url
+

Are you looking if the url startswith a string (find will give the index of the first match)? If so, I suggest .startswith() instead

+            if 'fennecIDs:' in line:
+                newline = 'fennecIDs: %s\n' % self.fennecIDs

Should use the new architecture, adding to replacements: http://hg.mozilla.org/build/talos/file/64ebd87ce9c7/talos/remotePerfConfigurator.py#l9

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: talos tweaks to get robocop tests to run (1.1)

incorporated feedback from comments

Comment 6

[Jeff Hammel]

Comment on attachment 595005 [details] [diff] [review]
talos tweaks to get robocop tests to run (1.1)

Looks good!  Assuming this is tested, looks good

It would be better if we didn't have to include the extension directly in Talos, but the current architecture doesn't really allow a better way, ABICT :/

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/build/talos/rev/8263f6cc9ec0