717140 - keyboard support for rebuilding jobs

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Trevor Saunders (:tbsaunde)]

It would be nice if it was possible to tab to the div / image that you click to  rebuild jobs, a key board short cut was also suggested as an added feature.

If pointed at source I'm be able to take a look at fixing this.

Comment 1

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/file/962932eba448/js/UserInterface.js#l1485 builds the linked images (for both rebuild and stop), various instances of "_keymap" in that same file do shortcuts, but I can't point at how shortcuts for things dealing with an individual selected job are done, because this would be the first one.

Now here's a fun question: since we do hair-trigger single key shortcuts, and since the same function creates both the rebuild and the stop buttons, should there be a shortcut for stop? We don't currently have any keyboard shortcut to select the next running or pending job, so currently kitty-typing couldn't stop more than the one job that you selected before walking away, but would a person wanting to implement a next-running-job shortcut realize that they shouldn't because we have a hair-trigger stop shortcut? (I don't mind the thought of kitty laying down on the "r" key and triggering infinite rebuilds quite as much, because that only uses up releng's resources, and conceivably leaves us short of some flavor of slave, which is less overall rage added to the world than the amount when a cat cancels every running build on try by rocking back and forth between the s and whatever would be next-running-build keys.)

Comment 2

[(no longer active)]

Maybe we should add kitty constraints as part of our commit agreement?  ;-)

Comment 3

[Trevor Saunders (:tbsaunde)]

Attachment: put buttons in the tab order

key commands might be nice, but this is good enough for my purposes.  I'm not sure who should review this stuff.

Comment 4

[Phil Ringnalda (:philor)]

Comment on attachment 592011 [details] [diff] [review]
put buttons in the tab order

If it's incredibly easy to review, me. If it requires some brains, swatinem or mstange.

Comment 5

[Trevor Saunders (:tbsaunde)]

(In reply to Phil Ringnalda (:philor) from comment #4)
> Comment on attachment 592011 [details] [diff] [review]
> put buttons in the tab order
> 
> If it's incredibly easy to review, me. If it requires some brains, swatinem
> or mstange.

I think that patch meets most definitions of incredibly easy :)

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 592011 [details] [diff] [review]
put buttons in the tab order

r=me since it's the right thing to do to be accessible, but boy howdy, without a screen reader to help you, that's a long way to tab.

Fifteen minutes after you push, it'll be live on https://tbpl-dev.allizom.org/ so you can make sure it's working like you expect, you can check that it's been pulled with https://tbpl-dev.allizom.org/cache/revision_info.txt and the not very secret username and password for tbpl-dev will be in your inbox in a minute.

Comment 7

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/f0f67707b200

Comment 8

[Trevor Saunders (:tbsaunde)]

(In reply to Phil Ringnalda (:philor) from comment #7)
> http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/
> f0f67707b200

thanks for taking care of that, I spent the weekend sick so didn't get back to this.