Closed Bug 717173 Opened 8 years ago Closed 8 years ago

Crash @ JS_ReportPendingException

Categories

(Core :: DOM: Core & HTML, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: scoobidiver, Assigned: bent.mozilla)

References

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file, 1 obsolete file)

It's a new crash signature that first appeared in 12.0a1/20120101.
The regression window is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8f658d460c3d&tochange=d77b056ed4bd

Stacks are various:
Frame 	Module 	Signature [Expand] 	Source
0 	XUL 	JS_ReportPendingException 	js/src/jsapi.cpp:6497
1 	XUL 	mozilla::dom::workers::WorkerRunnable::Dispatch 	dom/workers/WorkerPrivate.cpp:1545
2 	XUL 	mozilla::dom::workers::WorkerPrivateParent<mozilla::dom::workers::WorkerPrivate>::NotifyPrivate 	dom/workers/WorkerPrivate.cpp:1869
3 	XUL 	mozilla::dom::workers::WorkerPrivateParent<mozilla::dom::workers::WorkerPrivate>::FinalizeInstance
...

Frame 	Module 	Signature [Expand] 	Source
0 	xul.dll 	JS_ReportPendingException 	js/src/jsapi.cpp:6497
1 	mozutils.dll 	arena_run_dalloc 	memory/jemalloc/jemalloc.c:3776
2 	xul.dll 	mozilla::dom::workers::WorkerRunnable::PostDispatch 	dom/workers/WorkerPrivate.cpp:1620
3 	xul.dll 	mozilla::dom::workers::WorkerRunnable::Dispatch 	dom/workers/WorkerPrivate.cpp:1545
4 	nspr4.dll 	MD_CURRENT_THREAD 	nsprpub/pr/src/md/windows/w95thred.c:308
5 	mozutils.dll 	je_malloc 	memory/jemalloc/jemalloc.c:6306
6 	xul.dll 	mozilla::dom::workers::WorkerControlRunnable::WorkerControlRunnable 	dom/workers/WorkerPrivate.h:168
7 	mozutils.dll 	je_realloc 	memory/jemalloc/jemalloc.c:6525
8 	xul.dll 	nsRefPtr<mozilla::dom::indexedDB::IDBKeyRange>::nsRefPtr<mozilla::dom::indexedDB::IDBKeyRange> 	obj-firefox/dist/include/nsAutoPtr.h:931
9 	xul.dll 	mozilla::dom::workers::WorkerPrivateParent<mozilla::dom::workers::WorkerPrivate>::NotifyPrivate 	dom/workers/WorkerPrivate.cpp:1869
10 	xul.dll 	mozilla::dom::workers::WorkerPrivateParent<mozilla::dom::workers::WorkerPrivate>::FinalizeInstance
...

Frame 	Module 	Signature [Expand] 	Source
0 	mozjs.dll 	JS_ReportPendingException 	js/src/jsapi.cpp:6483
1 	xul.dll 	mozilla::dom::workers::WorkerRunnable::PostDispatch 	dom/workers/WorkerPrivate.cpp:1620
2 	xul.dll 	mozilla::dom::workers::WorkerRunnable::Dispatch 	dom/workers/WorkerPrivate.cpp:1545
3 	xul.dll 	mozilla::dom::workers::WorkerPrivateParent<mozilla::dom::workers::WorkerPrivate>::NotifyPrivate 	dom/workers/WorkerPrivate.cpp:1869
4 	xul.dll 	mozilla::dom::workers::WorkerPrivateParent<mozilla::dom::workers::WorkerPrivate>::TerminatePrivate 	dom/workers/WorkerPrivate.h:251
5 	xul.dll 	mozilla::dom::workers::WorkerPrivateParent<mozilla::dom::workers::WorkerPrivate>::FinalizeInstance 	dom/workers/WorkerPrivate.cpp:1961
6 	xul.dll 	`anonymous namespace'::ChromeWorker::Finalize 	dom/workers/Worker.cpp:402
...

More reports at:
https://crash-stats.mozilla.com/report/list?signature=JS_ReportPendingException
Attached patch Patch, v1 (obsolete) — Splinter Review
Oops.
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Attachment #587702 - Flags: review?(khuey)
Attachment #587702 - Flags: review?(jonas)
Comment on attachment 587702 [details] [diff] [review]
Patch, v1

Review of attachment 587702 [details] [diff] [review]:
-----------------------------------------------------------------

We want to avoid calling ModifyBusyCount with a null cx too, no?
Attached patch Patch, v2Splinter Review
Yeah, I thought they were safe, but they aren't.
Attachment #587702 - Attachment is obsolete: true
Attachment #587702 - Flags: review?(khuey)
Attachment #587702 - Flags: review?(jonas)
Attachment #587870 - Flags: review?(khuey)
https://hg.mozilla.org/mozilla-central/rev/b3b6bca8a02a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.