Closed
Bug 717223
Opened 13 years ago
Closed 13 years ago
Delayload linking of gkmedias.dll broke mingw compilation
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla12
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
1.19 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
MSVC-specific options are filtered by platform instead of compiler. The attached patch moves importing gkmedias.dll to the place where other delayload options are set.
Attachment #587675 -
Flags: review?(khuey)
Comment on attachment 587675 [details] [diff] [review]
fix v1.0
You need to move delayimp.lib too, no?
Attachment #587675 -
Flags: review?(khuey) → review-
|
Assignee | |
Comment 2•13 years ago
|
||
It's already there, see line 559 (in patched file):
OS_LIBS += $(call EXPAND_LIBNAME,delayimp)
Comment on attachment 587675 [details] [diff] [review]
fix v1.0
Review of attachment 587675 [details] [diff] [review]:
-----------------------------------------------------------------
Aha, that's what I get for searching for delayimp.lib.
r=me
Thanks for fixing this.
Attachment #587675 -
Flags: review- → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Thanks for review, pushed to m-i:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4089da57bff1
Whiteboard: [inbound]
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla12
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•