Delayload linking of gkmedias.dll broke mingw compilation

RESOLVED FIXED in mozilla12

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla12
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 587675 [details] [diff] [review]
fix v1.0

MSVC-specific options are filtered by platform instead of compiler. The attached patch moves importing gkmedias.dll to the place where other delayload options are set.
Attachment #587675 - Flags: review?(khuey)
Comment on attachment 587675 [details] [diff] [review]
fix v1.0

You need to move delayimp.lib too, no?
Attachment #587675 - Flags: review?(khuey) → review-
(Assignee)

Comment 2

6 years ago
It's already there, see line 559 (in patched file):

OS_LIBS += $(call EXPAND_LIBNAME,delayimp)
Comment on attachment 587675 [details] [diff] [review]
fix v1.0

Review of attachment 587675 [details] [diff] [review]:
-----------------------------------------------------------------

Aha, that's what I get for searching for delayimp.lib.

r=me 

Thanks for fixing this.
Attachment #587675 - Flags: review- → review+
(Assignee)

Comment 4

6 years ago
Thanks for review, pushed to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/4089da57bff1
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/4089da57bff1
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.