717224 - Misc libraries fail to link on mingw due to missing -luserenv

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jacek Caban]

Attachment: fix v1.0

MSVC builds use |#pragma comment(lib, "userenv.lib")| that is not supported in mingw. Since that file is compiled with many targets, maintaining it in OS_LIBS would be tricky. My patch adds userenv to default linked libraries. It won't affect targets that don't use it as it's skipped by linker if userenv is not used.

Comment 1

[Brian R. Bondy [:bbondy]]

If we're going to put it there I think we should remove the #pragma comment(lib, "userenv.lib") pls.

Comment 2

[Jacek Caban]

(In reply to Brian R. Bondy [:bbondy] from comment #1)
> If we're going to put it there I think we should remove the #pragma
> comment(lib, "userenv.lib") pls.

Note that with my patch it's still needed. I've added linker option in configure only for mingw builds, MSVC builds still use #pragma. I can move MSVC imports to configure as well if you prefer.

Comment 3

[Brian R. Bondy [:bbondy]]

Comment on attachment 587676 [details] [diff] [review]
fix v1.0

Review of attachment 587676 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry I didn't notice that, this looks good to me.

Comment 4

[Brian R. Bondy [:bbondy]]

Thanks for the patch.

Comment 5

[Jacek Caban]

Thanks for the review, pushed to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/d13c738c54ce

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/d13c738c54ce