Native methods do not create a MethodFrame entry, and thus aren't visible to a telemetry-based MF-stack-sampler

NEW
Unassigned

Status

Tamarin
Profiler
6 years ago
6 years ago

People

(Reporter: Edwin Smith, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
Q2 12 - Cyril

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Telemetry needs to take periodic stack samples by stack-walking MethodFrames.  Existing native stubs do not generate and link a MethodFrame instance, so those calls are invisible.

Comment 1

6 years ago
Created attachment 594339 [details] [diff] [review]
Telemetry based sampler implementation

Patch includes all the code needed for the new sampler implementation in the VM. Note that this sampler relies on a telemetry implementation (using the ITelemetry interface). All the relevant code is wrapped in the VMCFG_TELEMETRY_SAMPLER flag, which is controlled by AVMFEATURE_TELEMETRY_SAMPLER. The main sampler class is in the existing Sampler.cpp/.h files, in hopes that eventually it can just replace the existing sampler.

Updated

6 years ago
Attachment #594339 - Flags: superreview?(edwsmith)
Attachment #594339 - Flags: review?(ruchi.lohani)

Updated

6 years ago
Attachment #594339 - Flags: review?(ruchi.lohani) → review?(rulohani)

Comment 2

6 years ago
The attachment is for bug 724139 but also includes the fix for this bug as part of larger changes.

Comment 3

6 years ago
Created attachment 596745 [details] [diff] [review]
Native gen script changes

Updated patch to only include changes needed for this bug. This change is also part of the larger changes for bug 724139.
Attachment #594339 - Attachment is obsolete: true
Attachment #594339 - Flags: superreview?(edwsmith)
Attachment #594339 - Flags: review?(rulohani)
Attachment #596745 - Flags: superreview?(edwsmith)
Attachment #596745 - Flags: review?(rulohani)

Comment 4

6 years ago
Comment on attachment 596745 [details] [diff] [review]
Native gen script changes

Removing myself from review since this patch has been reviewed in another bug.
Attachment #596745 - Flags: review?(rulohani)
(Reporter)

Comment 5

6 years ago
Comment on attachment 596745 [details] [diff] [review]
Native gen script changes

Dropping SR? since patch is obsolete
Attachment #596745 - Flags: superreview?(edwsmith)
You need to log in before you can comment on or make changes to this bug.