717233 - Native methods do not create a MethodFrame entry, and thus aren't visible to a telemetry-based MF-stack-sampler

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Profiler, defect)

Description

[Edwin Smith]

Telemetry needs to take periodic stack samples by stack-walking MethodFrames.  Existing native stubs do not generate and link a MethodFrame instance, so those calls are invisible.

Comment 1

[George Comninos]

Attachment: Telemetry based sampler implementation

Patch includes all the code needed for the new sampler implementation in the VM. Note that this sampler relies on a telemetry implementation (using the ITelemetry interface). All the relevant code is wrapped in the VMCFG_TELEMETRY_SAMPLER flag, which is controlled by AVMFEATURE_TELEMETRY_SAMPLER. The main sampler class is in the existing Sampler.cpp/.h files, in hopes that eventually it can just replace the existing sampler.

Comment 2

[George Comninos]

The attachment is for bug 724139 but also includes the fix for this bug as part of larger changes.

Comment 3

[George Comninos]

Attachment: Native gen script changes

Updated patch to only include changes needed for this bug. This change is also part of the larger changes for bug 724139.

Comment 4

[Ruchi Lohani]

Comment on attachment 596745 [details] [diff] [review]
Native gen script changes

Removing myself from review since this patch has been reviewed in another bug.

Comment 5

[Edwin Smith]

Comment on attachment 596745 [details] [diff] [review]
Native gen script changes

Dropping SR? since patch is obsolete

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Tamarin is a dead project now. Mass WONTFIX.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.