Last Comment Bug 717240 - Remove incomplete add/edit image map code from editor
: Remove incomplete add/edit image map code from editor
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Composition (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 12.0
Assigned To: Mark Banner (:standard8)
:
Mentors:
Depends on:
Blocks: 700808
  Show dependency treegraph
 
Reported: 2012-01-11 07:55 PST by Mark Banner (:standard8)
Modified: 2012-01-14 09:59 PST (History)
2 users (show)
standard8: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
The fix (74.52 KB, patch)
2012-01-11 07:55 PST, Mark Banner (:standard8)
neil: superreview+
Details | Diff | Review
The fix v2 (91.33 KB, patch)
2012-01-12 11:34 PST, Mark Banner (:standard8)
iann_bugzilla: review+
Details | Diff | Review

Description Mark Banner (:standard8) 2012-01-11 07:55:24 PST
Created attachment 587700 [details] [diff] [review]
The fix

There's a bunch of code in editor/ui for adding/editing image maps.

I came across this whilst working on bug 700808 - the strings for the buttons are in non-suite specific ifdef, but the partial image map UI strings are in a suite specific ifdef.

I think we should just remove this code for now. Its obvious it doesn't work, and if we want to make it work later we can always pull it out of history. This also gives about 56 strings less for localisers to translate.

I have left the remove image map button in - afaict that would work.
Comment 1 Ian Neal 2012-01-11 08:37:52 PST
There is also a couple of css files in each of the suite themes, also referenced in an inspector test, that could probably be removed but that could be in a follow up:
EdImageMap.css
EdImageMapPage.css
Comment 2 neil@parkwaycc.co.uk 2012-01-11 09:12:19 PST
Comment on attachment 587700 [details] [diff] [review]
The fix

Yeah, the code is ancient and nowhere near working, so...
Comment 3 Mark Banner (:standard8) 2012-01-12 11:34:42 PST
Created attachment 588127 [details] [diff] [review]
The fix v2

Removes the css files as well. As far as I can tell Inspector doesn't actually use allskin.xul, so I'm going to file a bug about changing it or removing it.

The images referenced in the css files don't seem to exist either.
Comment 4 Ian Neal 2012-01-14 04:06:41 PST
Comment on attachment 588127 [details] [diff] [review]
The fix v2

r=me and thanks
Comment 5 Mark Banner (:standard8) 2012-01-14 09:59:57 PST
Checked in: http://hg.mozilla.org/comm-central/rev/81c392144beb

Note You need to log in before you can comment on or make changes to this bug.