Closed Bug 717240 Opened 14 years ago Closed 14 years ago

Remove incomplete add/edit image map code from editor

Categories

(MailNews Core :: Composition, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 12.0

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch The fix (obsolete) — — Splinter Review
There's a bunch of code in editor/ui for adding/editing image maps. I came across this whilst working on bug 700808 - the strings for the buttons are in non-suite specific ifdef, but the partial image map UI strings are in a suite specific ifdef. I think we should just remove this code for now. Its obvious it doesn't work, and if we want to make it work later we can always pull it out of history. This also gives about 56 strings less for localisers to translate. I have left the remove image map button in - afaict that would work.
Attachment #587700 - Flags: superreview?(neil)
Attachment #587700 - Flags: review?(iann_bugzilla)
There is also a couple of css files in each of the suite themes, also referenced in an inspector test, that could probably be removed but that could be in a follow up: EdImageMap.css EdImageMapPage.css
Comment on attachment 587700 [details] [diff] [review] The fix Yeah, the code is ancient and nowhere near working, so...
Attachment #587700 - Flags: superreview?(neil) → superreview+
Attached patch The fix v2 — — Splinter Review
Removes the css files as well. As far as I can tell Inspector doesn't actually use allskin.xul, so I'm going to file a bug about changing it or removing it. The images referenced in the css files don't seem to exist either.
Attachment #587700 - Attachment is obsolete: true
Attachment #587700 - Flags: review?(iann_bugzilla)
Attachment #588127 - Flags: review?(iann_bugzilla)
Comment on attachment 588127 [details] [diff] [review] The fix v2 r=me and thanks
Attachment #588127 - Flags: review?(iann_bugzilla) → review+
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: