B2G telephony: audio isn't switched on for incoming calls and never switched off once switched on

RESOLVED FIXED in mozilla12

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: philikon, Assigned: philikon)

Tracking

unspecified
mozilla12
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

v2
4.45 KB, patch
Details | Diff | Splinter Review
Another small regression from bug 674726: if we receive an incoming call, we never turn on audio and leave the audio system forever in the dial tone state, it seems. Also, if the first call we make is an outgoing call and the audio system is turned on, we never seem to turn it off again.
(Assignee)

Updated

5 years ago
Assignee: nobody → philipp
Created attachment 587864 [details] [diff] [review]
v1
Attachment #587864 - Flags: review?(bent.mozilla)
Comment on attachment 587864 [details] [diff] [review]
v1

>+  activeCall: null,

Let's make this '_activeCall'

>+  updateCallAudioState: function updateCallAudioState() {
>+    if (!this.activeCall ||
>+        this.activeCall.state == nsITelephone.CALL_STATE_DISCONNECTED) {

This second condition isn't possible, is it? I'd remove it.
Attachment #587864 - Flags: review?(bent.mozilla) → review+
Created attachment 587866 [details] [diff] [review]
v2

comments addressed
Attachment #587864 - Attachment is obsolete: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/289576c50802
https://hg.mozilla.org/mozilla-central/rev/289576c50802
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
(Assignee)

Updated

5 years ago
Depends on: 723372
You need to log in before you can comment on or make changes to this bug.