Last Comment Bug 717434 - B2G telephony: audio isn't switched on for incoming calls and never switched off once switched on
: B2G telephony: audio isn't switched on for incoming calls and never switched ...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: unspecified
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla12
Assigned To: Philipp von Weitershausen [:philikon]
:
Mentors:
Depends on: 723372
Blocks: webtelephony
  Show dependency treegraph
 
Reported: 2012-01-11 15:20 PST by Philipp von Weitershausen [:philikon]
Modified: 2012-02-01 17:55 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (3.84 KB, patch)
2012-01-11 16:07 PST, Philipp von Weitershausen [:philikon]
bent.mozilla: review+
Details | Diff | Splinter Review
v2 (4.45 KB, patch)
2012-01-11 16:15 PST, Philipp von Weitershausen [:philikon]
no flags Details | Diff | Splinter Review

Description Philipp von Weitershausen [:philikon] 2012-01-11 15:20:01 PST
Another small regression from bug 674726: if we receive an incoming call, we never turn on audio and leave the audio system forever in the dial tone state, it seems. Also, if the first call we make is an outgoing call and the audio system is turned on, we never seem to turn it off again.
Comment 1 Philipp von Weitershausen [:philikon] 2012-01-11 16:07:59 PST
Created attachment 587864 [details] [diff] [review]
v1
Comment 2 Ben Turner (not reading bugmail, use the needinfo flag!) 2012-01-11 16:12:41 PST
Comment on attachment 587864 [details] [diff] [review]
v1

>+  activeCall: null,

Let's make this '_activeCall'

>+  updateCallAudioState: function updateCallAudioState() {
>+    if (!this.activeCall ||
>+        this.activeCall.state == nsITelephone.CALL_STATE_DISCONNECTED) {

This second condition isn't possible, is it? I'd remove it.
Comment 3 Philipp von Weitershausen [:philikon] 2012-01-11 16:15:45 PST
Created attachment 587866 [details] [diff] [review]
v2

comments addressed
Comment 4 Philipp von Weitershausen [:philikon] 2012-01-11 16:21:18 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/289576c50802
Comment 5 Matt Brubeck (:mbrubeck) 2012-01-12 11:01:10 PST
https://hg.mozilla.org/mozilla-central/rev/289576c50802

Note You need to log in before you can comment on or make changes to this bug.