717434 - B2G telephony: audio isn't switched on for incoming calls and never switched off once switched on

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Philipp von Weitershausen [:philikon]]

Another small regression from bug 674726: if we receive an incoming call, we never turn on audio and leave the audio system forever in the dial tone state, it seems. Also, if the first call we make is an outgoing call and the audio system is turned on, we never seem to turn it off again.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 587864 [details] [diff] [review]
v1

>+  activeCall: null,

Let's make this '_activeCall'

>+  updateCallAudioState: function updateCallAudioState() {
>+    if (!this.activeCall ||
>+        this.activeCall.state == nsITelephone.CALL_STATE_DISCONNECTED) {

This second condition isn't possible, is it? I'd remove it.

Comment 3

[Philipp von Weitershausen [:philikon]]

Attachment: v2

comments addressed

Comment 4

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/289576c50802

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/289576c50802